From nobody Wed Mar 22 21:46:39 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PhhrL0266z41Lbn; Wed, 22 Mar 2023 21:46:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PhhrK6g5fz3Lmp; Wed, 22 Mar 2023 21:46:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679521601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YIP9XiEnwr4ZuipwIaH4Yb/JEombDV93dpGnRqEOS1s=; b=i96mY4QOCQHWHGkCkrSl9IbWGDaeNEOzebgBZIpoJlIc9A+AjDvnkM/jugrEFRoCmnbAYv 4YWgoaz+eGExcvjXiMv/4xavbjrRGCmjQmZfsC55p02xhEggJ8JW/uP3DZ+S7fSkKWkx8s djZknIc4pFj+4SqV1al7k4baWq39eLZpR9w0Kq64k/fSHQuDERims9+IYLK6FL/NTylqFz X+TpIItkAytZBz12GopXtn2osaXa06nr7q0PdF0S9wYrRr7+rRBE9j3zic+oPHa6TU8j5m Si6lS+5IGwn+WFfSzWxeYjOSUOeYVYM7H1bsrXfPG74V6dphQ7jJo3on9xJAgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679521601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YIP9XiEnwr4ZuipwIaH4Yb/JEombDV93dpGnRqEOS1s=; b=RDzUKsuUgcRRZCfQKgjrVFHCgOWNRSMl9uY8cvRpR82MYmhMidMKMAgNcy6CZfM8wRdlI/ gUf3lSxyFzzWD3+DNoUCzCPql+4v/mR9KWGwxDffMi9idmQ/OIjhwfgv4q5pf/Et344B/0 PbAbxTn1TbZDYE45vPRHm8+DiVTUWavvY69+r0Wswz6usH6wLn1Ych0W1NPSpOfO3xnuCl Gl9WKpBIciWiCcZKG/DAC3h3u1gwhu+s9zg6yuzBzQ1XrDXCP72dzbENbC04ZjDxyrAMpe jvHVuUTOYL2K0v9Az046dQygFu/ww3lKBKyEvAodLZUksNL7OlzXnLAKyqoHwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679521601; a=rsa-sha256; cv=none; b=IcWLzHBMJOdEtB+PzrUIghAmns+ei2X4mt6sLV/bpgOvkccEEw2q0QnyQn1zmJ/qBMkl7q e8dixbIREej3GEBv4D2sU+IPbAUXjxV7lc7LGef2oi7nYETyqwnOEEYkNyYbzxveXFY4rh 05EzKgxReQWePt0353vQXZNe+MPYDE+cap0RHEj13QjJ/qMncshw53zkvecYA4A7EYt4+W ZtRusFxATQpGNvUkypxYnHgriyQbNdaV/34h321TEj6yiK5Yd6PHGk0N+6sBBmQ2tAdDbx 8u9EExe4hawAs6tXcYBJyPU8C0Lzu7N3D94+9OfgHmObSLCdVdVY/EcXwNuHrg== Received: from [IPV6:2601:648:8680:16b0:cc93:2ec:c80c:1599] (unknown [IPv6:2601:648:8680:16b0:cc93:2ec:c80c:1599]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PhhrK2TF0zGmq; Wed, 22 Mar 2023 21:46:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Wed, 22 Mar 2023 14:46:39 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: git: 61482760a0ca - main - bhyve: Accept a variable-length string name for qemu_fwcfg_add_file. Content-Language: en-US To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202303221935.32MJZlHM019772@gitrepo.freebsd.org> <29CA9EB9-4226-4FB0-982E-A88A8BC5ACCB@freebsd.org> From: John Baldwin In-Reply-To: <29CA9EB9-4226-4FB0-982E-A88A8BC5ACCB@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 3/22/23 12:44 PM, Jessica Clarke wrote: > On 22 Mar 2023, at 19:35, John Baldwin wrote: >> >> The branch main has been updated by jhb: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=61482760a0ca198a9310d450133e9ac792b67955 >> >> commit 61482760a0ca198a9310d450133e9ac792b67955 >> Author: John Baldwin >> AuthorDate: 2023-03-22 19:34:34 +0000 >> Commit: John Baldwin >> CommitDate: 2023-03-22 19:34:34 +0000 >> >> bhyve: Accept a variable-length string name for qemu_fwcfg_add_file. >> >> It is illegal (UB?) to pass a shorter array to a function argument >> that takes a fixed-length array. Do a runtime check for names that >> are too long via strlen() instead. > > So, without static in there (that very weird corner of the C grammar*), > the size is meaningless. GCC just treats this as a convention that you > meant the size to do something for the purposes of diagnostics, but not > semantics, so this is in fact a known, and by design, false-positive. Humm, ok. I'd probably still rather pacify the warning rather than silence the warning as it finds real bugs in other places. -- John Baldwin