From owner-svn-src-all@freebsd.org Tue Dec 3 20:43:15 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8480E1BCE04; Tue, 3 Dec 2019 20:43:15 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47SDTH1t2lz3R50; Tue, 3 Dec 2019 20:43:14 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id xB3KhDF8025942 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 3 Dec 2019 12:43:13 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id xB3KhDq1025941; Tue, 3 Dec 2019 12:43:13 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Tue, 3 Dec 2019 12:43:13 -0800 From: Gleb Smirnoff To: Ryan Libby Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355137 - head/sys/vm Message-ID: <20191203204313.GB2706@FreeBSD.org> References: <201911271949.xARJnuFl084178@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201911271949.xARJnuFl084178@repo.freebsd.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47SDTH1t2lz3R50 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.78 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.90)[-0.904,0]; NEURAL_HAM_LONG(-0.87)[-0.871,0]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Dec 2019 20:43:15 -0000 Ryan, On Wed, Nov 27, 2019 at 07:49:56PM +0000, Ryan Libby wrote: R> Author: rlibby R> Date: Wed Nov 27 19:49:55 2019 R> New Revision: 355137 R> URL: https://svnweb.freebsd.org/changeset/base/355137 R> R> Log: R> uma: trash memory when ctor/dtor supplied too R> R> On INVARIANTS kernels, UMA has a use-after-free detection mechanism. R> This mechanism previously required that all of the ctor/dtor/uminit/fini R> arguments to uma_zcreate() be NULL in order to function. Now, it only R> requires that uminit and fini be NULL; now, the trash ctor and dtor will R> be called in addition to any supplied ctor or dtor. R> R> Also do a little refactoring for readability of the resulting logic. R> R> This enables use-after-free detection for more zones, and will allow for R> simplification of some callers that worked around the previous R> restriction (see kern_mbuf.c). R> R> Reviewed by: jeff, markj R> Sponsored by: Dell EMC Isilon R> Differential Revision: https://reviews.freebsd.org/D20722 If I understand the change correct, now items from UMA_ZONE_NOFREE zones will be trashed, too. That would undermine purpose of UMA_ZONE_NOFREE. Of course the flag is a hack, but some systems rely on it working. -- Gleb Smirnoff