From owner-p4-projects Thu Jun 27 9:59:19 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 919D037B40E; Thu, 27 Jun 2002 09:58:43 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from green.bikeshed.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 71B8437B405; Thu, 27 Jun 2002 09:58:22 -0700 (PDT) Received: from localhost (green@localhost) by green.bikeshed.org (8.11.6/8.11.6) with ESMTP id g5RGwNP39104; Thu, 27 Jun 2002 12:58:23 -0400 (EDT) (envelope-from green@green.bikeshed.org) Message-Id: <200206271658.g5RGwNP39104@green.bikeshed.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: chris@FreeBSD.org Cc: Brian Feldman , Perforce Change Reviews Subject: Re: PERFORCE change 13476 for review In-Reply-To: Your message of "Thu, 27 Jun 2002 09:14:58 CDT." <20020627091458.C412@holly.calldei.com> From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 27 Jun 2002 12:58:22 -0400 Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Chris Costello wrote: > On Thursday, June 27, 2002, Brian Feldman wrote: > > Don't crash if an ELF module is b0rked and has a 0 where it > > shouldn't. Maybe I should just let it crash? > > More sanity/validity checks for KLD files is probably for the > best. I can't see how you could go wrong in preventing an > unnecessary crash, but I think printing a log message like > "filename: Invalid ELF header" or the like would be a good idea > as well. Well, the lingering thought in my mind against it is that if the KLD file is really corrupt it could just as easily have a data segment that will crash you when it starts executing. I'm not sure what the right trade-off here is. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org <> bfeldman@tislabs.com \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message