Date: Thu, 27 Jun 2002 12:58:22 -0400 From: "Brian F. Feldman" <green@FreeBSD.org> To: chris@FreeBSD.org Cc: Brian Feldman <green@FreeBSD.org>, Perforce Change Reviews <perforce@FreeBSD.org> Subject: Re: PERFORCE change 13476 for review Message-ID: <200206271658.g5RGwNP39104@green.bikeshed.org> In-Reply-To: Your message of "Thu, 27 Jun 2002 09:14:58 CDT." <20020627091458.C412@holly.calldei.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Chris Costello <chris@FreeBSD.org> wrote: > On Thursday, June 27, 2002, Brian Feldman wrote: > > Don't crash if an ELF module is b0rked and has a 0 where it > > shouldn't. Maybe I should just let it crash? > > More sanity/validity checks for KLD files is probably for the > best. I can't see how you could go wrong in preventing an > unnecessary crash, but I think printing a log message like > "filename: Invalid ELF header" or the like would be a good idea > as well. Well, the lingering thought in my mind against it is that if the KLD file is really corrupt it could just as easily have a data segment that will crash you when it starts executing. I'm not sure what the right trade-off here is. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org <> bfeldman@tislabs.com \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200206271658.g5RGwNP39104>