From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Apr 11 05:50:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 94C96698 for ; Thu, 11 Apr 2013 05:50:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 7B6D0126 for ; Thu, 11 Apr 2013 05:50:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3B5o0cu027981 for ; Thu, 11 Apr 2013 05:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3B5o0CX027980; Thu, 11 Apr 2013 05:50:00 GMT (envelope-from gnats) Resent-Date: Thu, 11 Apr 2013 05:50:00 GMT Resent-Message-Id: <201304110550.r3B5o0CX027980@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jason Helfman Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id AB00A546 for ; Thu, 11 Apr 2013 05:44:03 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 8ED4ED9 for ; Thu, 11 Apr 2013 05:44:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3B5i3K2027863 for ; Thu, 11 Apr 2013 05:44:03 GMT (envelope-from jgh@freefall.freebsd.org) Received: (from jgh@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3B5i3Tw027862; Thu, 11 Apr 2013 05:44:03 GMT (envelope-from jgh) Message-Id: <201304110544.r3B5i3Tw027862@freefall.freebsd.org> Date: Thu, 11 Apr 2013 05:44:03 GMT From: Jason Helfman To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: ports/177775: multimedia/gtk-youtube-viewer: properly support dependency for CLI option X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Jason Helfman List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2013 05:50:00 -0000 >Number: 177775 >Category: ports >Synopsis: multimedia/gtk-youtube-viewer: properly support dependency for CLI option >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Apr 11 05:50:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Jason Helfman >Release: FreeBSD 10.0-CURRENT amd64 >Organization: >Environment: System: FreeBSD freefall.freebsd.org 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r249172: Sat Apr 6 00:40:01 UTC 2013 peter@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL amd64 >Description: If you choose CLI, dependencies are still pointed to lang/perl5.14 With this update, it will be require lang/perl5.16, and note which entry for UPDATING to read, as well as properly clean up. Updates USER_INTERFACE to UI for group naming Drop enable from descriptions. Drop post-extract target, as this is no longer required. Adjust pkg-plist accordingly for support of an additional perl version. >How-To-Repeat: >Fix: Index: multimedia/gtk-youtube-viewer/Makefile =================================================================== --- multimedia/gtk-youtube-viewer/Makefile (revision 315781) +++ multimedia/gtk-youtube-viewer/Makefile (working copy) @@ -3,7 +3,7 @@ PORTNAME= gtk-youtube-viewer PORTVERSION= 3.0.7 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= multimedia perl5 MAINTAINER= nemysis@gmx.ch @@ -35,7 +35,6 @@ WRKSRC= ${WRKDIR}/${GH_ACCOUNT}-${GH_PROJECT}-${GH_COMMIT}/WWW-YoutubeViewer CONFIGURE_ARGS+=${DATADIR} -PERL_MODBUILD= yes MAN3= WWW::YoutubeViewer::RegularExpressions.3 \ WWW::YoutubeViewer.3 \ @@ -48,21 +47,26 @@ OPTIONS_DEFINE= GCAP -OPTIONS_MULTI= USER_INTERFACE -OPTIONS_MULTI_USER_INTERFACE= CLI GTK2 +OPTIONS_MULTI= UI +OPTIONS_MULTI_UI= CLI GTK2 OPTIONS_DEFAULT= GTK2 GCAP -CLI_DESC= Enable CLI version -GCAP_DESC= Enable YouTube captions support +CLI_DESC= CLI version (requires perl5.16) +GCAP_DESC= YouTube captions support .include .if ${PORT_OPTIONS:MCLI} MAN1= youtube-viewer.1 PLIST_SUB+= CLI="" +PERL_MODBUILD= 5.16+ +USE_PERL5_RUN= 5.16+ +USE_PERL5_REASON= Requires Perl 5.16 or later, install lang/perl5.16 and try again. \ + Please read ${PORTSDIR}/UPDATING entry from 20120630 after installation. .else PLIST_SUB+= CLI="@comment " +PERL_MODBUILD= YES .endif .if ${PORT_OPTIONS:MGTK2} @@ -78,17 +82,6 @@ RUN_DEPENDS+= ${LOCALBASE}/bin/gcap:${PORTSDIR}/multimedia/gcap .endif -post-extract: -.if ! exists(${LOCALBASE}/bin/per5.16.2) - @${ECHO_CMD} - @${ECHO_MSG} "GTK Youtube Viewer 3.07 requires lang/perl5.16 to use CLI version" - @${ECHO_MSG} - @${ECHO_MSG} "Please read /usr/ports/UPDATING" - @${ECHO_MSG} - @${ECHO_MSG} "Hit ^c now if you don't wish to do this." - @${ECHO_MSG} -.endif - post-patch: @${REINPLACE_CMD} -n '1,/create_build_script()/p' \ ${WRKSRC}/Build.PL Index: multimedia/gtk-youtube-viewer/pkg-plist =================================================================== --- multimedia/gtk-youtube-viewer/pkg-plist (revision 315781) +++ multimedia/gtk-youtube-viewer/pkg-plist (working copy) @@ -27,6 +27,6 @@ @dirrm %%SITE_PERL%%/WWW @dirrm %%SITE_PERL%% @dirrmtry lib/perl5/site_perl -@dirrmtry lib/perl5/5.14.2/man -@dirrmtry lib/perl5/5.14.2 +@dirrmtry lib/perl5/%%PERL_VER%%/man +@dirrmtry lib/perl5/%%PERL_VER%% @dirrmtry lib/perl5 >Release-Note: >Audit-Trail: >Unformatted: