Date: Wed, 23 Oct 2019 03:23:14 +0000 (UTC) From: Kyle Evans <kevans@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r353914 - head/lib/libcasper/services/cap_sysctl Message-ID: <201910230323.x9N3NEH6057994@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kevans Date: Wed Oct 23 03:23:14 2019 New Revision: 353914 URL: https://svnweb.freebsd.org/changeset/base/353914 Log: cap_sysctl: correct typo from r347534-ish operation & ~limit where limit is a bool is clearly not what was intended, given the line prior. Correct it to use the calculated mask for validation. The cap_sysctl tests should now be functional again. Modified: head/lib/libcasper/services/cap_sysctl/cap_sysctl.c Modified: head/lib/libcasper/services/cap_sysctl/cap_sysctl.c ============================================================================== --- head/lib/libcasper/services/cap_sysctl/cap_sysctl.c Wed Oct 23 03:15:27 2019 (r353913) +++ head/lib/libcasper/services/cap_sysctl/cap_sysctl.c Wed Oct 23 03:23:14 2019 (r353914) @@ -316,7 +316,7 @@ sysctl_valid(const nvlist_t *nvl, bool limit) */ mask = limit ? (CAP_SYSCTL_RDWR | CAP_SYSCTL_RECURSIVE) : CAP_SYSCTL_RDWR; - if ((operation & ~limit) != 0 || + if ((operation & ~mask) != 0 || (operation & CAP_SYSCTL_RDWR) == 0) return (EINVAL); /* Only one 'operation' can be present. */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201910230323.x9N3NEH6057994>