From owner-freebsd-bugs@FreeBSD.ORG Tue Jul 28 14:10:01 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7D501065702 for ; Tue, 28 Jul 2009 14:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A3FB88FC1C for ; Tue, 28 Jul 2009 14:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6SEA18r007811 for ; Tue, 28 Jul 2009 14:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6SEA1nE007810; Tue, 28 Jul 2009 14:10:01 GMT (envelope-from gnats) Resent-Date: Tue, 28 Jul 2009 14:10:01 GMT Resent-Message-Id: <200907281410.n6SEA1nE007810@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Eygene Ryabinkin Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05B511065737 for ; Tue, 28 Jul 2009 14:09:45 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id 5E5AC8FC16 for ; Tue, 28 Jul 2009 14:09:44 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from void.codelabs.ru (void.codelabs.ru [144.206.177.25]) by 0.mx.codelabs.ru with esmtps (TLSv1:CAMELLIA256-SHA:256) id 1MVnN9-000HJl-Ah for FreeBSD-gnats-submit@freebsd.org; Tue, 28 Jul 2009 18:09:43 +0400 Message-Id: <20090728140943.38D05DA81D@void.codelabs.ru> Date: Tue, 28 Jul 2009 18:09:43 +0400 (MSD) From: Eygene Ryabinkin To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/137213: [patch][cleanup] eliminate wrong usages of (S)LIST_HEAD_INITIALIZER macro X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Eygene Ryabinkin List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2009 14:10:02 -0000 >Number: 137213 >Category: kern >Synopsis: [patch][cleanup] eliminate wrong usages of (S)LIST_HEAD_INITIALIZER macro >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jul 28 14:10:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Eygene Ryabinkin >Release: FreeBSD 8.0-BETA1 amd64 >Organization: Code Labs >Environment: System: FreeBSD 8.0-BETA1 amd64 >Description: Some pieces of the kernel use ----- LIST_HEAD(listhead, entry) head = LIST_HEAD_INITIALIZER(&head); ----- instead of ----- LIST_HEAD(listhead, entry) head = LIST_HEAD_INITIALIZER(head); ----- >From the functional point of view, this change is no-op for the current queue.h implementation, since LIST_HEAD_INITIALIZER just returns '{NULL}' and its argument is unused. But it is good to have semantically-correct code. >How-To-Repeat: ----- cd /usr/src/sys; grep -r 'LIST_HEAD_INITIALIZER(&' * man LIST_HEAD_INITIALIZER ----- >Fix: The following patch changes all occurrences I had found within the kernel. --- proper-argument-to-LIST_HEAD_INITIALIZER.diff begins here --- begin 644 proper-argument-to-LIST_HEAD_INITIALIZER.diff M1G)O;2`X8C`X-6,R-#@V83=A.30V,F9C,69C9F%B865B,&$T-#%D.3=A-#`X M($UO;B!397`@,3<@,#`Z,#`Z,#`@,C`P,0I&6=E;F4@4GEA8FEN M:VEN(#QR96$M9F)S9$!C;V1E;&%B2D@:&5A9"`]"B`@("`@("`@($Q)4U1?2$5!1%]) M3DE424%,25I%4BAH96%D*3L*+2TM+2T*86YD(&YO=`HM+2TM+0H@("`@($Q) M4U1?2$5!1"AL:7-T:&5A9"P@96YT6%B:6YK:6X@/')E82UF8G-D0&-O9&5L86)S+G)U/@HM+2T* M(&-O;G1R:6(O8G-N;7`OPH@"4Q)4U1?14Y44EDH;6%C%]T(&YA;65D7W-E;7-?;71X(#T@4%1(4D5!1%]-551%6%])3DE4 M24%,25I%4CL*(`H@7U]W96%K7W)E9F5R96YC92A?7W-E;5]I;FET+"!S96U? M:6YI="D["F1I9F8@+2UG:70@82]L:6(O;&EB9W-S87!I+V=S"!F96(X.&8Q+BYD,#=D8C@X(#$P,#8T-`HM+2T@82]L:6(O;&EB9W-S87!I M+V=SPH@"7)P8U]GPH@"4-,245.5%].15"`U,F0R M-#(X+BXS8C)A,&$U(#$P,#8T-`HM+2T@82]S8FEN+V=G871E+V=G871E9"]G M9V%T960N8PHK*RL@8B]S8FEN+V=G871E+V=G871E9"]G9V%T960N8PI`0"`M M.3DL."`K.3DL."!`0"!S=&%T:6,@5$%)3%%?2$5!1"@L(&=G9%]R97%U97-T M*2!O=71Q=65U92`](%1!24Q17TA%041?24Y)5$E!3$E:15(H;W5T<75E=64I M.PH@<'1H%]T(&EN<75E=65?;71X+"!O=71Q=65U95]M='@[ M"B!P=&AR96%D7V-O;F1?="!I;G%U975E7V-O;F0L(&]U='%U975E7V-O;F0[ M"B`*+7-T871I8R!33$E35%](14%$*"P@9V=D7V5X<&]R="D@97AP;W)T"`T-#4P-S=F+BYF-F(S9F1B(#$P,#8T-`HM+2T@82]S8FEN M+VYA=&0O;F%T9"YC"BLK*R!B+W-B:6XO;F%T9"]N871D+F,*0$`@+38X+#<@ M*S8X+#<@0$`@7,O9&5V+VMS>6US+VMS>6US+F,@ M8B]S>7,O9&5V+VMS>6US+VMS>6US+F,*:6YD97@@9F,S-CAC-RXN8F-A-C0T M."`Q,#`V-#0*+2TM(&$O6US7V1E=CL*('-T871I8R!, M25-47TA%040H+"!K6US7VQI6US7VQI6US7W-H7,O9&5V+VQE9"]L960N8R!B+W-Y"!L961?;71X.PH@"`X-V4U86,Y+BXR,#`V,#DY(#$P,#8T M-`HM+2T@82]S>7,O9&5V+VUD+VUD+F,**RLK(&(OF5O9BAU:6YT<'1R7W0I*0H@(V1E9FEN92!. M34%32PDH3DE.1$E2+3$I"F1I9F8@+2UG:70@82]S>7,O9V5O;2]G871E+V=? M9V%T92YC(&(O"`S-S,W964P M+BXR-F1F,&8T(#$P,#8T-`HM+2T@82]S>7,O9V5O;2]G871E+V=?9V%T92YC M"BLK*R!B+W-Y5]T('-S8W-TPH@"2YP`D] M($I!24Q?34%8+`H@"2YP7,O:V5R;B]V9G-?;6]U;G0N8PII;F1E>"`W83$S-S$Y M+BXU8C$V8S$X(#$P,#8T-`HM+2T@82]S>7,O:V5R;B]V9G-?;6]U;G0N8PHK M*RL@8B]S>7,O:V5R;B]V9G-?;6]U;G0N8PI`0"`M,3,T.2PW("LQ,S0Y+#<@ M0$`@7,O;F5T+W!F M:6PN8R!B+W-Y7,O;F5T:6YE="]I<%]E;F-A M<"YC"FEN9&5X(#!E9F0R,F$N+F-E,3,Q.60@,3`P-C0T"BTM+2!A+W-Y"!E;F-A<&UT>#L*($U46%]365-)3DE4 M*&5N8V%P;71X+"`F96YC87!M='@L(")E;F-A<&UT>"(L($U46%]$148I.PHM M3$E35%](14%$*"P@96YC87!T86(I(&5N8V%P=&%B(#T@3$E35%](14%$7TE. M251)04Q)6D52*"9E;F-A<'1A8BD["BM,25-47TA%040H+"!E;F-A<'1A8BD@ M96YC87!T86(@/2!,25-47TA%041?24Y)5$E!3$E:15(H96YC87!T86(I.PH@ M"B`O*@H@("H@5V4@8W5RPH@ M"4-,245.5%].157,O=FTO=6UA7V-O7-T96T@*B\*+7-T871I8R!,25-47TA%040H+'5M85]K M96"!U;6%?;71X.PH@"B`O*B!,:6YK960@;&ES="!O9B!B;V]T('1I;64@<&%G M97,@*B\*('-T871I8R!,25-47TA%040H+'5M85]S;&%B*2!U;6%?8F]O=%]P M86=E"!P#L*9&EF9B`M+6=I="!A+W1O;VQS+W)E9W)E"`X8S4U,6-F+BXU.3EA.34S(#$P,#8T-`HM M+2T@82]T;V]L"`X8C-C83%D+BYB,&5F.6$S(#$P,#8T-`HM M+2T@82]URelease-Note: >Audit-Trail: >Unformatted: