From owner-freebsd-net Fri Dec 24 19:58:27 1999 Delivered-To: freebsd-net@freebsd.org Received: from dustdevil.waterspout.com (dial-282.bford.kiva.net [208.233.253.26]) by hub.freebsd.org (Postfix) with ESMTP id AAFDC151F3 for ; Fri, 24 Dec 1999 19:58:25 -0800 (PST) (envelope-from csg@waterspout.com) Received: by dustdevil.waterspout.com (Postfix, from userid 1000) id 1F1C7A7; Fri, 24 Dec 1999 23:05:01 -0500 (EST) Date: Fri, 24 Dec 1999 23:05:01 -0500 From: "C. Stephen Gunn" To: Garrett Wollman Cc: freebsd-net@freebsd.org Subject: Re: 802.1Q VLAN support in FreeBSD Message-ID: <19991224230501.A83392@dustdevil.waterspout.com> References: <19991218220304.B97641@titan.klemm.gtn.com> <199912201851.NAA73090@khavrinen.lcs.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0pre3i In-Reply-To: <199912201851.NAA73090@khavrinen.lcs.mit.edu> Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Mon, Dec 20, 1999 at 01:51:36PM -0500, Garrett Wollman wrote: > I am concerned at the size of the patches. Most of the patch to > if_ethersubr.c is bogus -- that's what the code in if_vlan.c is > supposed to do. I agree, the patches to if_ethersubr.c definitely duplicate the code in if_vlan.c. I will try to (after the holidays) read the patches to see what this code actually changes functionally, and graft any improvements into if_vlan.c and subit a patch. - Steve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message