From owner-freebsd-net@FreeBSD.ORG Tue Dec 11 18:30:13 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 719B916A41A for ; Tue, 11 Dec 2007 18:30:13 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outE.internet-mail-service.net (outE.internet-mail-service.net [216.240.47.228]) by mx1.freebsd.org (Postfix) with ESMTP id 611AD13C46E for ; Tue, 11 Dec 2007 18:30:13 +0000 (UTC) (envelope-from julian@elischer.org) Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160) by out.internet-mail-service.net (qpsmtpd/0.40) with ESMTP; Tue, 11 Dec 2007 10:30:12 -0800 X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38]) by idiom.com (Postfix) with ESMTP id DD59C126C7A; Tue, 11 Dec 2007 10:30:11 -0800 (PST) Message-ID: <475ED72E.9000200@elischer.org> Date: Tue, 11 Dec 2007 10:30:06 -0800 From: Julian Elischer User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: "Li, Qing" References: <475E4C45.2050206@elischer.org> <20071211004853.A51465@xorpc.icir.org> <305C539CA2F86249BF51CDCE8996AFF408FC5B14@bcs-mail2.internal.cacheflow.com> <475ED25C.2000204@elischer.org> In-Reply-To: <475ED25C.2000204@elischer.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Luigi Rizzo , ales.cerri@tiscali.it, FreeBSD Net Subject: Re: arp rewrite... X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2007 18:30:13 -0000 Julian Elischer wrote: > Li, Qing wrote: >> Last time when I sent an email to net@ for comments, I >> received only limited feedback. >> The New ARP code in my home directory on FreeFall and was >> lasted updated on June-8-2007. It was based on then CURRENT >> (7.0) and was tested to be working fine at >> that time. A bit more work would be necessary in locking >> though. I asked for code review and folks to play with it. >> Again, the feedback was really scant. >> The code is accessible at >> http://people.freebsd.org/~qingli/newarp-06-08-2007/ >> >> The question I asked then was "should I move forward?" >> >> I'd be more that happy to resume and be done with it. > > I think that breaking the arp code from the routing code > need to proceed. > > I see no reason to not have reference counted links from the routes to > the arp code (for optimisation and compat reasons), > but it should be self standing. > > I'll look at what you have.. it looks very good. (could do with a few more comments :-) What I'm trying to do in my current project is add limited support for multiple routing tables into 6.x or at latest 7.x I have a 'low impact' version that gives "limited" support. //depot/user/julian/routing/src/sys/... (userland utility not in p4 yet) i.e. you can select from a small number (defined at compile time) of tables for ipv4 only.. it will do for my purposes, but should have little impact on the API/ABI. in -current the requirement for ABI compatibility is not there so I can do proper rewrite. Which I think would include a rewrite of the arp code. I like what I see in the code you have done.. It's a bit hard reading you code as patches, is it in P4? > > >> >> -- Qing >> >> >>> -----Original Message----- >>> From: owner-freebsd-net@freebsd.org >>> [mailto:owner-freebsd-net@freebsd.org] On Behalf Of Luigi Rizzo >>> Sent: Tuesday, December 11, 2007 12:49 AM >>> To: Julian Elischer; ales.cerri@tiscali.it >>> Cc: FreeBSD Net >>> Subject: Re: arp rewrite... >>> >>> On Tue, Dec 11, 2007 at 12:37:25AM -0800, Julian Elischer wrote: >>>> I believe Qing-li (Sp?) did an arp rewrite.. >>> the story is a bit longer - Andre drafted the initial design, which i >>> subsequently took over and with a student, Alessandro Cerri, (I am >>> Cc-ing him) did a first implementation. This was probably around 2003. >>> >>> Then Qing-li (Sp?) took over development of that code - last i heard >>> of the code was around last summer. >>> >>> I think our code at least was based on 4.x so it probably did not >>> address locking very much (not sure how the routing code is locked >>> these days, anyways). >>> >>> Alessandro is actually around again playing with FreeBSD so he may >>> remember more details (it was his thesis, after all!) >>> >>> cheers >>> luigi >>> _______________________________________________ >>> freebsd-net@freebsd.org mailing list >>> http://lists.freebsd.org/mailman/listinfo/freebsd-net >>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >>> > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"