From owner-cvs-all Sat Dec 4 17:16:46 1999 Delivered-To: cvs-all@freebsd.org Received: from ind.alcatel.com (postal.xylan.com [208.8.0.248]) by hub.freebsd.org (Postfix) with ESMTP id E682214E9D; Sat, 4 Dec 1999 17:16:36 -0800 (PST) (envelope-from wes@softweyr.com) Received: from mailhub.xylan.com (mailhub [198.206.181.70]) by ind.alcatel.com (8.9.3+Sun/8.9.1 (ind.alcatel.com 3.0 [OUT])) with SMTP id RAA12751; Sat, 4 Dec 1999 17:13:59 -0800 (PST) X-Origination-Site: Received: from omni.xylan.com by mailhub.xylan.com (SMI-8.6/SMI-SVR4 (mailhub 2.1 [HUB])) id RAA05161; Sat, 4 Dec 1999 17:13:58 -0800 Received: from softweyr.com ([204.68.178.39]) by omni.xylan.com (4.1/SMI-4.1 (xylan engr [SPOOL])) id AA29491; Sat, 4 Dec 99 17:13:55 PST Message-Id: <3849BC64.8244888A@softweyr.com> Date: Sat, 04 Dec 1999 18:14:12 -0700 From: Wes Peters Organization: Softweyr LLC X-Mailer: Mozilla 4.61 [en] (X11; I; FreeBSD 3.3-RELEASE i386) X-Accept-Language: en Mime-Version: 1.0 To: mjacob@feral.com Cc: "Matthew N. Dodd" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_bus.c References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Matthew Jacob wrote: > > I believe it *is* reasonable to ask the following: > > If you make a change to the kernel, clearly you must have > compiled it and tested it yourself. Please make sure that you > do a compile and test with up to date merged sources *before* the > CVS commit. If, during the merge/update for the last test, > somebody has changed sys/param.h and you have to rebuild > completely, well, that's bad luck for you[1]. If you have all > architectures supported, please do this for both architectures > unless the files you change do not affect the other architecture > at all. Agreed. Please note this applies to /bin, /sbin, and critical library functions as well. Imagine how useful your system will be when I manage to break getpw*. I haven't yet, but getgr* is in pretty sad shape on my system right now. What a morass of static buffers. It is intriguing to see what things do and don't work when you install a seriously broken shared library. -- "Where am I, and what am I doing in this handbasket?" Wes Peters Softweyr LLC wes@softweyr.com http://softweyr.com/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message