From owner-p4-projects@FreeBSD.ORG Mon Jan 12 02:05:47 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5DDD01065672; Mon, 12 Jan 2009 02:05:47 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D0ED106564A for ; Mon, 12 Jan 2009 02:05:47 +0000 (UTC) (envelope-from weongyo.jeong@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.177]) by mx1.freebsd.org (Postfix) with ESMTP id DD7BF8FC1D for ; Mon, 12 Jan 2009 02:05:46 +0000 (UTC) (envelope-from weongyo.jeong@gmail.com) Received: by wa-out-1112.google.com with SMTP id m34so5877162wag.27 for ; Sun, 11 Jan 2009 18:05:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:to:cc:subject :message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent:organization :x-operation-sytem:from; bh=MSDcP12TK4R5kB57+HB78+xYkjiLuzU2CY6am/fJDPA=; b=Qqlff+dvi87U87lB46zIpt2xOxDBnXOx1fW6KjpXZZwRRjMDGk8pJnFG6mNgzjFWYo 2PyhR90udNmp2nqDj3rc/naYB/PVsnwzvD3FTGliNdRvh6uIzXAlcrvMMAgWGH0PgwYt DHlaZkP4WYppc7zk16om73ywKcdI9rNc6IMOA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent :organization:x-operation-sytem:from; b=Xv8vxo38VfedMcL1ajW0VOF6SD+/ag4CpcB3GjOuQpJ7CwA6xsFUn28D4O3JLueJzn QxFxPBzdR8yXLwyC4RFGpIahs7QFdEphM0zMEn5pPlbGu/XRdVeBojmn7XNQbpQYYn5S FWSrPeK9k3rx2pi7Eg5SU1Fb2sCkP/LehVogA= Received: by 10.115.110.15 with SMTP id n15mr18679070wam.144.1231724031197; Sun, 11 Jan 2009 17:33:51 -0800 (PST) Received: from freebsd.weongyo.org ([211.53.35.67]) by mx.google.com with ESMTPS id m29sm44617209poh.6.2009.01.11.17.33.48 (version=SSLv3 cipher=RC4-MD5); Sun, 11 Jan 2009 17:33:50 -0800 (PST) Received: by freebsd.weongyo.org (sSMTP sendmail emulation); Mon, 12 Jan 2009 10:33:31 +0900 Date: Mon, 12 Jan 2009 10:33:31 +0900 To: Hans Petter Selasky Message-ID: <20090112013331.GA29564@freebsd.weongyo.org> References: <200901100859.n0A8xdmW025069@repoman.freebsd.org> <200901101138.02533.hselasky@c2i.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200901101138.02533.hselasky@c2i.net> User-Agent: Mutt/1.4.2.3i Organization: CDNetworks. X-Operation-Sytem: FreeBSD From: Weongyo Jeong Cc: Perforce Change Reviews Subject: Re: PERFORCE change 155896 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Weongyo Jeong List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jan 2009 02:05:48 -0000 On Sat, Jan 10, 2009 at 11:38:01AM +0100, Hans Petter Selasky wrote: > On Saturday 10 January 2009, Weongyo Jeong wrote: > > http://perforce.freebsd.org/chv.cgi?CH=155896 > > > > Change 155896 by weongyo@weongyo_ws on 2009/01/10 08:59:26 > > > > In USB 2.0 specification The USB System Software should guarantees > > a minumum of 10ms for reset recovery but it looks the USB1 framework > > doesn't follow it. So it looks sometimes it failed to re-attach or > > reenumerate devices after the device reset. > > > > With this patch, the fw loading operation of uath(4) works. > > > > Affected files ... > > > > .. //depot/projects/vap/sys/dev/usb/usb.c#8 edit > > > > Hi, > > This is not the right place to patch. > > I think this delay belongs somewhere in "uhub.c". Please search for the > following defines in the code: > > #define USB_PORT_RESET_DELAY 50 /* ms */ > #define USB_PORT_ROOT_RESET_DELAY 250 /* ms */ > #define USB_PORT_RESET_RECOVERY 250 /* ms */ > > There should already be a delay there. Maybe you need to increase one of these > macros. Oops. Ok I'll try to fix it. Thank you for noticing about it. regards, Weongyo Jeong