Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 May 2018 12:28:02 +1000
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Waitman Gobble <waitman@waitman.net>
Cc:        "Vanilla I. Shu" <vanilla@FreeBSD.org>, python <python@FreeBSD.org>
Subject:   Re: svn commit: r471040 - in head/devel: . py-pyformance
Message-ID:  <5b23b612-3064-c9b2-275f-857da4b27c2a@FreeBSD.org>
In-Reply-To: <201805281242.w4SCgbgN082615@repo.freebsd.org>
References:  <201805281242.w4SCgbgN082615@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 28/05/2018 10:42 pm, Vanilla I. Shu wrote:
> Author: vanilla
> Date: Mon May 28 12:42:37 2018
> New Revision: 471040
> URL: https://svnweb.freebsd.org/changeset/ports/471040
> 
> Log:
>    Add py-pyformance 0.4, pyFormance is a toolset for performance
>    measurement and statistics.
>    
>    PR:		228527
>    Submitted by:	Waitman Gobble <waitman@waitman.net>
> 
> Added:
>    head/devel/py-pyformance/
>    head/devel/py-pyformance/Makefile   (contents, props changed)
>    head/devel/py-pyformance/distinfo   (contents, props changed)
>    head/devel/py-pyformance/pkg-descr   (contents, props changed)
> Modified:
>    head/devel/Makefile
> 
> Modified: head/devel/Makefile
> ==============================================================================
> --- head/devel/Makefile	Mon May 28 11:49:41 2018	(r471039)
> +++ head/devel/Makefile	Mon May 28 12:42:37 2018	(r471040)
> @@ -4824,6 +4824,7 @@
>       SUBDIR += py-pyface
>       SUBDIR += py-pyfcm
>       SUBDIR += py-pyflakes
> +    SUBDIR += py-pyformance
>       SUBDIR += py-pygdbmi
>       SUBDIR += py-pygit2
>       SUBDIR += py-pygithub
> 
> Added: head/devel/py-pyformance/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/py-pyformance/Makefile	Mon May 28 12:42:37 2018	(r471040)
> @@ -0,0 +1,28 @@
> +# Created by: Waitman Gobble <waitman@waitman.net>
> +# $FreeBSD$
> +
> +PORTNAME=	pyformance
> +PORTVERSION=	0.4
> +CATEGORIES=	devel python
> +MASTER_SITES=	CHEESESHOP
> +PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
> +
> +MAINTAINER=	python@FreeBSD.org

Thank you for your new python port contribution Waitman

While we (python) are happy to be default maintainers in some cases, and 
fallback maintainers in most others cases, new port submitters are 
strongly encouraged, if not already required by defacto or documented 
policy, to maintain ports themselves in the first instance, as there are 
ongoing responsibilities of creating a port:

https://www.freebsd.org/doc/en_US.ISO8859-1/articles/contributing/ports-contributing.html#maintain-port

It would be great if you could update the port MAINTAINER line to 
yourself, after creating a bugzilla account with the same address, so 
that you can be informed of new port bugs automatically.

> +COMMENT=	PyFormance is a toolset for performance measurement and statistics

Can probably strip this "X is a" part of COMMENT.

Also, it looks like there is a missing RUN_DEPENDS on six:

   setup.py: install_requires = ['six'] # optional: ["blinker==1.2"]

> +
> +LICENSE=	APACHE20
> +LICENSE_FILE=	${WRKSRC}/LICENSE
> +
> +OPTIONS_DEFINE=	DOCS
> +
> +NO_ARCH=	yes
> +USES=		python
> +USE_PYTHON=	autoplist distutils
> +
> +PORTDOCS=	README.md
> +
> +post-install-DOCS-on:
> +	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> +	${INSTALL_DATA} ${WRKSRC}/README.md ${STAGEDIR}${DOCSDIR}
> +
> +.include <bsd.port.mk>
> 
> Added: head/devel/py-pyformance/distinfo
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/py-pyformance/distinfo	Mon May 28 12:42:37 2018	(r471040)
> @@ -0,0 +1,3 @@
> +TIMESTAMP = 1527390802
> +SHA256 (pyformance-0.4.tar.gz) = 2fd16397961ff62f2b2e7300e0abb2afd2b7e996e6075afae666922636d07029
> +SIZE (pyformance-0.4.tar.gz) = 20683
> 
> Added: head/devel/py-pyformance/pkg-descr
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/py-pyformance/pkg-descr	Mon May 28 12:42:37 2018	(r471040)
> @@ -0,0 +1,5 @@
> +PyFormance is a toolset for performance measurement
> +and statistics, with a signaling mechanism that
> +allows to issue events in cases of unexpected behavior.
> +
> +WWW: https://pypi.org/project/pyformance/
> 




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5b23b612-3064-c9b2-275f-857da4b27c2a>