From owner-svn-src-head@freebsd.org  Sat Sep  9 12:51:20 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A615E14E6D;
 Sat,  9 Sep 2017 12:51:20 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id EAFA268155;
 Sat,  9 Sep 2017 12:51:19 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id C14832600CA;
 Sat,  9 Sep 2017 14:51:17 +0200 (CEST)
Subject: Re: svn commit: r323351 -
 head/sys/compat/linuxkpi/common/include/linux
To: "Andrey V. Elsukov" <bu7cher@yandex.ru>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201709090721.v897LRWA084296@repo.freebsd.org>
 <1b752f11-2ec8-4c07-d53a-9e32a5fcf56c@yandex.ru>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <00d891a5-3fb7-5562-7f3d-645083779492@selasky.org>
Date: Sat, 9 Sep 2017 14:48:52 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1b752f11-2ec8-4c07-d53a-9e32a5fcf56c@yandex.ru>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Sep 2017 12:51:20 -0000

On 09/09/17 13:10, Andrey V. Elsukov wrote:
> On 09.09.2017 10:21, Hans Petter Selasky wrote:
>> Author: hselasky
>> Date: Sat Sep  9 07:21:27 2017
>> New Revision: 323351
>> URL: https://svnweb.freebsd.org/changeset/base/323351
>>
> 
> This doesn't look right. We use s6_addr16[1] to keep scope zone id.
> And if_index value should be converted into network byte order. It is
> quite usual to have more that 255 interfaces.
> 
> And what is more important, you must not use this code for global IPv6
> addresses.
> 

Hi,

Thank you for your comments. This function is only used for interface 
specific addresses. Anyway, I'll make the requested changes!

https://svnweb.freebsd.org/changeset/base/323364

--HPS