From owner-svn-src-all@freebsd.org Sun Feb 9 18:53:54 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 85F4223F3FC; Sun, 9 Feb 2020 18:53:54 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Fyqk2jSSz4QCc; Sun, 9 Feb 2020 18:53:54 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 584C5AB76; Sun, 9 Feb 2020 18:53:54 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 019IrsTh054317; Sun, 9 Feb 2020 18:53:54 GMT (envelope-from kevans@FreeBSD.org) Received: (from kevans@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 019IrsaI054316; Sun, 9 Feb 2020 18:53:54 GMT (envelope-from kevans@FreeBSD.org) Message-Id: <202002091853.019IrsaI054316@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: kevans set sender to kevans@FreeBSD.org using -f From: Kyle Evans Date: Sun, 9 Feb 2020 18:53:54 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r357703 - head/share/mk X-SVN-Group: head X-SVN-Commit-Author: kevans X-SVN-Commit-Paths: head/share/mk X-SVN-Commit-Revision: 357703 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Feb 2020 18:53:54 -0000 Author: kevans Date: Sun Feb 9 18:53:53 2020 New Revision: 357703 URL: https://svnweb.freebsd.org/changeset/base/357703 Log: mips: mark GOOGLETEST broken, due to no fault of its own As explained in the comment; GOOGLETEST cannot currently be compiled on any mips variant at the moment due to the cross toolchain seemingly using the wrong spec and not pulling in libgcc. We'll be fine when llvm 10 lands, at which point this should be reverted most expeditiously. Modified: head/share/mk/src.opts.mk Modified: head/share/mk/src.opts.mk ============================================================================== --- head/share/mk/src.opts.mk Sun Feb 9 15:13:56 2020 (r357702) +++ head/share/mk/src.opts.mk Sun Feb 9 18:53:53 2020 (r357703) @@ -348,7 +348,12 @@ BROKEN_OPTIONS+=LIB32 BROKEN_OPTIONS+=LIBSOFT .endif .if ${__T:Mmips*} -BROKEN_OPTIONS+=SSP +# GOOGLETEST cannot currently be compiled on mips due to external circumstances. +# Notably, the freebsd-gcc port isn't linking in libgcc so we end up trying ot +# link to a hidden symbol. LLVM would successfully link this in, but some of +# the mips variants are broken under LLVM until LLVM 10. GOOGLETEST should be +# marked no longer broken with the switch to LLVM. +BROKEN_OPTIONS+=GOOGLETEST SSP .endif # EFI doesn't exist on mips, powerpc, sparc or riscv. .if ${__T:Mmips*} || ${__T:Mpowerpc*} || ${__T:Msparc64} || ${__T:Mriscv*}