From owner-freebsd-hackers  Thu Aug 24 18:10:22 1995
Return-Path: hackers-owner
Received: (from majordom@localhost)
          by freefall.FreeBSD.org (8.6.11/8.6.6) id SAA14304
          for hackers-outgoing; Thu, 24 Aug 1995 18:10:22 -0700
Received: from Root.COM (implode.Root.COM [198.145.90.17])
          by freefall.FreeBSD.org (8.6.11/8.6.6) with ESMTP id SAA14298
          for <hackers@freebsd.org>; Thu, 24 Aug 1995 18:10:21 -0700
Received: from corbin.Root.COM (corbin [198.145.90.34]) by Root.COM (8.6.11/8.6.5) with ESMTP id SAA10125; Thu, 24 Aug 1995 18:09:20 -0700
Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.11/8.6.5) with SMTP id SAA00647; Thu, 24 Aug 1995 18:11:14 -0700
Message-Id: <199508250111.SAA00647@corbin.Root.COM>
To: terry@cs.weber.edu (Terry Lambert)
cc: hackers@freebsd.org
Subject: Re: sys/malloc.h 
In-reply-to: Your message of "Thu, 24 Aug 95 16:36:57 MDT."
             <9508242236.AA09192@cs.weber.edu> 
From: David Greenman <davidg@Root.COM>
Reply-To: davidg@Root.COM
Date: Thu, 24 Aug 1995 18:11:13 -0700
Sender: hackers-owner@freebsd.org
Precedence: bulk

>Some kernel memory allocation issues:
>
>1)	Does it seem to anyone else as if the statistic's gathering
>	macros on the MALLOC/FREE are rather bizarre?

   I'd say that was a matter of opinion, but they make sense to me.

>2)	Has anyone else noticed the mixing of FREE/free on cn_pnbuf
>	elements of nameidata structures?  Doesn't this seem broken,
>	considering the use of MALLOC in the non-'HASBUF' case for
>	allocation in all cases in vfs_lookup.c?  Won't this fail
>	for the case of a kernel without either KMEMSTATS or
>	DIAGNOSTIC defined?

   The KMEMSTATS #ifdefs are bogus and should be removed. I had removed them
once in my local sources but the changes got lost. We always gather malloc
stats in FreeBSD - the information is just too important to be without.

-DG