From owner-cvs-all@FreeBSD.ORG Tue May 1 18:34:07 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C580A16A40A; Tue, 1 May 2007 18:34:07 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 716D313C48C; Tue, 1 May 2007 18:34:07 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A5FF4A.dip.t-dialin.net [84.165.255.74]) by redbull.bpaserver.net (Postfix) with ESMTP id AB96D2E12E; Tue, 1 May 2007 20:33:59 +0200 (CEST) Received: from deskjail (deskjail.Leidinger.net [192.168.1.109]) by outgoing.leidinger.net (Postfix) with ESMTP id C0C0B5B48A0; Tue, 1 May 2007 20:33:44 +0200 (CEST) Date: Tue, 1 May 2007 20:33:56 +0200 From: Alexander Leidinger To: Roman Kurakin Message-ID: <20070501203356.739710f8@deskjail> In-Reply-To: <46372416.3020509@inse.ru> References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501105937.GC823@turion.vk2pj.dyndns.org> <46372416.3020509@inse.ru> X-Mailer: Claws Mail 2.9.1 (GTK+ 2.10.11; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.864, required 8, autolearn=not spam, BAYES_00 -15.00, DK_POLICY_SIGNSOME 0.00, FORGED_RCVD_HELO 0.14) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: src-committers@freebsd.org, Andrey Chernov , cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 18:34:07 -0000 Quoting Roman Kurakin (Tue, 01 May 2007 15:27:18 +0400): > Peter Jeremy wrote: > > Note that just building the ports with these changes will not demonstrate > > much. This change alters the functionality of putenv() rather than the > > API/ABI so testing the change requires exercising the ports. This is > > a much more difficult task. > > > I suggest to install all ports sources and grep them at first. I am sure > some of ports > could be marked as bug-less and other should be marked for exec-check or > probably > for more accurate review not just grep. I can not remember to have seen something like this in the past 5 years since I'm a committer or since the last ... maybe 8 or 10 years since I follow current@ and cvs-all@. And there where a lot of changes which affected the ports. And may I remind you that we talk about following POSIX so most of the programs we have in the ports should be ok? I agree that it may have been more nice if there was a HEADS-UP first (the age old behavior changes), and I agree that re@ should have had a chance to voice their opinion, but after reading all the mails so far I would say a lot of people are exaggerating. Andrey, if it helps, here are some virtual hugs from me. Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137