From owner-freebsd-bugs@freebsd.org Mon Jan 29 23:21:18 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 80805EE49A4 for ; Mon, 29 Jan 2018 23:21:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1D3086C51B for ; Mon, 29 Jan 2018 23:21:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 6893E15B3A for ; Mon, 29 Jan 2018 23:21:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w0TNLHHo072741 for ; Mon, 29 Jan 2018 23:21:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w0TNLH5u072740 for freebsd-bugs@FreeBSD.org; Mon, 29 Jan 2018 23:21:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 225546] "zpool add" crashes in the presence of a replacing vdev with a spare child Date: Mon, 29 Jan 2018 23:21:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 23:21:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D225546 --- Comment #1 from commit-hook@freebsd.org --- A commit references this bug: Author: asomers Date: Mon Jan 29 23:20:30 UTC 2018 New revision: 328569 URL: https://svnweb.freebsd.org/changeset/base/328569 Log: Add a regression test for PR 225546 If a pool contains a replacing vdev with a spare child, then any "zpool add" command will fail. It doesn't matter whether you're adding a regular vdev, log, cache, or spare vdev. The bug is in get_replication in zpool_vdev.c in the zpool command. tests/sys/cddl/zfs/tests/cli_root/zpool_add/Makefile tests/sys/cddl/zfs/tests/cli_root/zpool_add/zpool_add_010_pos.ksh tests/sys/cddl/zfs/tests/cli_root/zpool_add/zpool_add_test.sh Add a test case that creates a pool with replacing vdev that has a spare child, then attempts to add another spare. tests/sys/cddl/zfs/include/commands.txt Add an alias for /usr/bin/timeout PR: 225546 Sponsored by: Spectra Logic Corp Changes: projects/zfsd/head/tests/sys/cddl/zfs/include/commands.txt projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zpool_add/Makefile =20 projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zpool_add/zpool_add_01= 0_pos.ksh =20 projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zpool_add/zpool_add_te= st.sh --=20 You are receiving this mail because: You are the assignee for the bug.=