From owner-svn-ports-all@freebsd.org Tue Jul 7 09:54:13 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B0B2698F35F; Tue, 7 Jul 2015 09:54:13 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8C3A81A52; Tue, 7 Jul 2015 09:54:12 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [192.168.0.22] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 9E5CB43C18; Tue, 7 Jul 2015 04:54:03 -0500 (CDT) Subject: Re: svn commit: r391493 - head/cad/tkgate To: Vsevolod Stakhov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201507070635.t676Zaqw085725@repo.freebsd.org> <559B9C36.2060300@FreeBSD.org> From: John Marino X-Enigmail-Draft-Status: N1110 Reply-To: marino@freebsd.org Message-ID: <559BA1B2.4050002@marino.st> Date: Tue, 7 Jul 2015 11:53:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <559B9C36.2060300@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2015 09:54:13 -0000 On 7/7/2015 11:30 AM, Vsevolod Stakhov wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 07/07/2015 07:35, John Marino wrote: >> Author: marino Date: Tue Jul 7 06:35:35 2015 New Revision: 391493 >> URL: https://svnweb.freebsd.org/changeset/ports/391493 >> >> Log: cad/tkgate: Unbreak FreeBSD 11, Fix depends on rest >> >> This was specified on USES: iconv:build,lib >> >> This is incorrect; the way iconv.mk is written, "build" and "lib" >> are mutually exclusive and "build" takes precedence. This means >> the library dependency was not registered. >> >> Moveover, it's failing on FreeBSD 11 and dev-branch of DragonFly >> because it uses transliteration. Setting USES=iconv:translit fixes >> both issues. >> >> Approved by: Just fix it > > Well, from your commit message I can conclude merely that iconv.mk is > broken by design. It is what it is. Just look at Mk/Uses/iconv.mk By definition, LIB_DEPENDS pulls in the port for building. This is true for all ports. > Secondly, I don't understand the meaning of > 'translit' option - it is damn confusing name and I cannot see clearly > what does it mean in the context of dependencies. It means the libc iconv isn't good enough and you need the ports libiconv. > Thirdly, isn't it a > polite policy to send a notice to a maintainer *before* committing > some change to port? If the port is broken, it's broken. "Just fix it" means if somebody knows how to fix breakage shown on portsmon, we can do. (You're welcome; I did send a courtesy message seconds after this commit) > I'm not arguing about the change itself, but I do > not understand this 'Just fix it policy' when it's absolutely unclear, > well at least for me, whether there's a problem with iconv.mk or with > the port definition. Weren't you getting pkg-fallout messages for FreeBSD 11? The problem is with the port. iconv changed on FreeBSD 11. John P.S. You revived this port incorrectly; all the history was lost. Next time please follow this procedure: https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-re-adding