Date: Wed, 18 Jul 2012 02:07:39 +0300 From: Alex Kozlov <spam@rm-rf.kiev.ua> To: Niclas Zeising <zeising@freebsd.org>, Doug Barton <dougb@dougbarton.us> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r301039 - head/archivers/zlib Message-ID: <20120717230739.GA66332@ravenloft.kiev.ua> In-Reply-To: <5005E5C4.2030809@freebsd.org> References: <201207172057.q6HKvEJc094784@svn.freebsd.org> <5005DB51.7050809@dougbarton.us> <5005E5C4.2030809@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 18, 2012 at 12:23:00AM +0200, Niclas Zeising wrote: > On 07/17/12 23:38, Doug Barton wrote: > > Was this causing you some sort of specific problem? AFAIK this happens > > often, possibly as a result of 'make makesum'. "Fixing" this everyplace > > that it occurs would almost certainly cause a lot of needless churn. Actually, it's pretty rare occurrence, so it does not add much churn. Also while harmless, this is still an error, like unused variable or typo. I agree that ideally this type of change should be committed with other changes, but it's hard to achieve because usually successive commits are made by different committers. Would be even better to find out why it happens at all, but i've done thousands of tests and still can't reproduce it with make makesum. > I was asked by ak@ to fix it in this specific instance. I forgot to > mention that in the commit message, unfortunately. It's not necessary. -- Alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120717230739.GA66332>