From nobody Thu Jul 3 20:50:10 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bY8Cw2XHpz618rc; Thu, 03 Jul 2025 20:55:08 +0000 (UTC) (envelope-from ruslan.bukin@cl.cam.ac.uk) Received: from smtp-2.srv.uis.cam.ac.uk (smtp-2.srv.uis.cam.ac.uk [128.232.132.148]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bY8Cw1vxxz4741; Thu, 03 Jul 2025 20:55:08 +0000 (UTC) (envelope-from ruslan.bukin@cl.cam.ac.uk) Authentication-Results: mx1.freebsd.org; none X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Received: from svr-postfix-1.cl.cam.ac.uk ([128.232.119.160]:29271) by smtp-2.srv.uis.cam.ac.uk with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1uXQxW-00000007f5J-4kYh; Thu, 03 Jul 2025 21:55:06 +0100 Received: from alloy (mail.bsdpad.com [91.99.52.19]) (Authenticated sender: rb743+mutt) by svr-postfix-1.cl.cam.ac.uk (Postfix) with ESMTPSA id 2013B40953; Thu, 3 Jul 2025 20:54:45 +0000 (UTC) Date: Thu, 3 Jul 2025 21:50:10 +0100 From: Ruslan Bukin To: A FreeBSD User Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: df114daef4c4 - main - Import the Hardware Trace (HWT) framework. Message-ID: References: <202507031503.563F35kp095569@gitrepo.freebsd.org> <20250703181943.4476444d@thor.sb211.local> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250703181943.4476444d@thor.sb211.local> X-Rspamd-Queue-Id: 4bY8Cw1vxxz4741 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:786, ipnet:128.232.0.0/16, country:GB] On Thu, Jul 03, 2025 at 06:19:16PM +0200, A FreeBSD User wrote: > > The commit breaks buildkernel: > > [...] > /usr/src/sys/dev/hwt/hwt_contexthash.c:82:2: error: call to undeclared function > 'spinlock_enter'; ISO C99 and later do not support implicit function declarations > [-Werror,-Wimplicit-function-declaration] 82 | HWT_CTXHASH_LOCK(); | ^ > /usr/src/sys/dev/hwt/hwt_contexthash.h:39:28: note: expanded from macro 'HWT_CTXHASH_LOCK' > 39 | #define HWT_CTXHASH_LOCK() mtx_lock_spin(&hwt_contexthash_mtx) > Dear FreeBSD user, thanks for your report. This should now be fixed. Could you confirm it builds? Roseland