From owner-freebsd-bugs@FreeBSD.ORG Tue Jun 9 18:57:32 2015 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D76AF7F0 for ; Tue, 9 Jun 2015 18:57:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C196B11B5 for ; Tue, 9 Jun 2015 18:57:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t59IvWSu033385 for ; Tue, 9 Jun 2015 18:57:32 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 200740] KASSERT panic due to race between GEOM tasting and withering Date: Tue, 09 Jun 2015 18:57:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: smferris@gmail.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2015 18:57:32 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200740 Bug ID: 200740 Summary: KASSERT panic due to race between GEOM tasting and withering Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: smferris@gmail.com Created attachment 157577 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=157577&action=edit wither-taste.diff disk_gone() can happen at any time due to hardware failures, and start withering GEOM devices. If something closes a device at about the same time, g_access() can queue an event that will call g_new_provider_event(), and the provider may have G_PF_WITHER set by the time g_new_provider_event() gets called, which panics a debug kernel. The attached patch replaces the KASSERT with a check of G_PF_WITHER, and just returns if it's set, since it doesn't make sense to taste a device that's going away. -- You are receiving this mail because: You are the assignee for the bug.