From owner-cvs-src@FreeBSD.ORG  Mon Jul  7 00:47:35 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 613B337B401; Mon,  7 Jul 2003 00:47:35 -0700 (PDT)
Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8F37943FA3; Mon,  7 Jul 2003 00:47:34 -0700 (PDT)
	(envelope-from obrien@NUXI.com)
Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1])
	by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h677lNaQ027780;
	Mon, 7 Jul 2003 00:47:23 -0700 (PDT)
	(envelope-from obrien@dragon.nuxi.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h677lMQ3027779;
	Mon, 7 Jul 2003 00:47:22 -0700 (PDT)
Date: Mon, 7 Jul 2003 00:47:22 -0700
From: "David O'Brien" <obrien@FreeBSD.org>
To: "M. Warner Losh" <imp@bsdimp.com>
Message-ID: <20030707074722.GA27746@dragon.nuxi.com>
References: <20030707003216.GI72093@elvis.mu.org>
	<p05210650bb2e737f369a@[128.113.24.47]>
	<20030707040326.GB26228@dragon.nuxi.com>
	<20030706.225203.52907520.imp@bsdimp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030706.225203.52907520.imp@bsdimp.com>
User-Agent: Mutt/1.4i
X-Operating-System: FreeBSD 5.1-CURRENT
Organization: The NUXI BSD Group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
cc: cvs-src@FreeBSD.org
cc: bright@mu.org
cc: drosih@rpi.edu
cc: src-committers@FreeBSD.org
cc: charnier@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c ...
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: obrien@FreeBSD.org
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jul 2003 07:47:35 -0000

On Sun, Jul 06, 2003 at 10:52:03PM -0600, M. Warner Losh wrote:
> In message: <20030707040326.GB26228@dragon.nuxi.com>
>             "David O'Brien" <obrien@FreeBSD.org> writes:
> : On Sun, Jul 06, 2003 at 09:20:37PM -0400, Garance A Drosihn wrote:
> : > Well, any change to use __FBSDID() has to #include <sys/cdefs.h>
> : > to get FBSDID() to work.  Of course, /usr/include/sys/cdefs.h
> : > does not exist on all platforms either (and is certainly not
> : > likely to define __FBSDID even if the file does exist), so that's
> : > just more of an annoyance when I'm doing cross-platform work.
> : 
> : #ifdef __FreeBSD__
> : #include <sys/cdefs.h>
> : __FBSDID("$FreeBSD$");
> : #endif
> 
> #include <sys/cdefs.h>
> #ifdef __FBSDID
> __FBSDID("$FreeBSD$");
> #endif
> 
> might be better...

Not really -- Garance needed to deal with <sys/cdefs.h> not existing
everywhere -- that was one of his key issues.
 
-- 
-- David  (obrien@FreeBSD.org)