From owner-freebsd-net@FreeBSD.ORG  Tue Jun 13 07:16:06 2006
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A9CE216A418
	for <freebsd-net@freebsd.org>; Tue, 13 Jun 2006 07:16:06 +0000 (UTC)
	(envelope-from Susan.Lan@zyxel.com.tw)
Received: from zyadd226.zyxel.com.tw (zyadd226.zyxel.com.tw [61.222.65.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E050E43D48
	for <freebsd-net@freebsd.org>; Tue, 13 Jun 2006 07:16:03 +0000 (GMT)
	(envelope-from Susan.Lan@zyxel.com.tw)
Received: from zytwbe01.zyxel.com ([172.23.5.10]) by smtp.zyxel.com.tw with
	InterScan Messaging Security Suite; Tue, 13 Jun 2006 15:24:11 +0800
Received: from zytwfe01.ZyXEL.com ([172.23.5.5]) by zytwbe01.zyxel.com with
	Microsoft SMTPSVC(6.0.3790.1830); Tue, 13 Jun 2006 15:15:59 +0800
Received: from [172.23.17.39] ([172.23.17.39]) by zytwfe01.ZyXEL.com with
	Microsoft SMTPSVC(6.0.3790.1830); Tue, 13 Jun 2006 15:15:59 +0800
Message-ID: <448E6635.4010800@zyxel.com.tw>
Date: Tue, 13 Jun 2006 15:16:05 +0800
From: Blue <Susan.Lan@zyxel.com.tw>
User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: freebsd-net@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 13 Jun 2006 07:15:59.0311 (UTC)
	FILETIME=[386895F0:01C68EB9]
Subject: [FreeBSD6.1-RELEASE]problem about soisconnected() in uipc_socket2.c
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Jun 2006 07:16:06 -0000

Hi,all:

I have found a questionable code in soisconnected() function in 
uipc_socket2.c. In the very beginning, the SOCK_LOCK() would lock the 
socket. However, in line 127, it unlocks socket. I am wondering that 
SOCK_UNLOCK() should be called until all the socket's parameters are 
done. In my opinion, it should be located right before ACCEPT_UNLOCK().

Best regards,

blue