Date: Wed, 6 May 2009 15:05:07 GMT From: Alberto Villa <villa.alberto@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/134273: [patch] multimedia/ffmpeg - avoid crash in multimedia/kdenlive Message-ID: <200905061505.n46F57IW071029@www.freebsd.org> Resent-Message-ID: <200905061510.n46FA17w081029@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 134273
>Category: ports
>Synopsis: [patch] multimedia/ffmpeg - avoid crash in multimedia/kdenlive
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed May 06 15:10:00 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Alberto Villa
>Release: FreeBSD 7-STABLE
>Organization:
>Environment:
FreeBSD echo.hoth 7.2-STABLE FreeBSD 7.2-STABLE #4: Mon May 4 14:19:14 CEST 2009 root@echo.hoth:/usr/obj/usr/src/sys/TPR60 i386
>Description:
update libavformat/avidec.c to avoid a crash in inigo, the mlt renderer used by multimedia/kdenlive
>How-To-Repeat:
import a clip in kdenlive and sometimes this will result in a segmentation fault
>Fix:
here's the patch to be put in files/ (it has been taken from a new svn version of ffmpeg, so it's code made in ffmpeg and just works)
Patch attached with submission follows:
--- libavformat/avidec.c.old 2008-10-16 10:30:37.000000000 +0000
+++ libavformat/avidec.c 2008-10-16 10:32:22.000000000 +0000
@@ -1026,8 +1026,9 @@
continue;
// assert(st2->codec->block_align);
- assert(st2->time_base.den == ast2->rate);
- assert(st2->time_base.num == ast2->scale);
+ assert((int64_t)st2->time_base.num*ast2->rate == (int64_t)st2->time_base.den*ast2->scale);
+// assert(st2->time_base.den == ast2->rate);
+// assert(st2->time_base.num == ast2->scale);
index = av_index_search_timestamp(
st2,
av_rescale(timestamp, st2->time_base.den*(int64_t)st->time_base.num, st->time_base.den * (int64_t)st2->time_base.num),
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905061505.n46F57IW071029>