Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Mar 2022 21:38:38 +0800
From:      Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        Adriaan de Groot <adridg@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org
Subject:   Re: git: b71f7e3faa71 - main - graphics/gdal: switch to C++17 for upcoming poppler
Message-ID:  <CAMHz58S4G1bzq58VYv8GSuwh8t7%2BOyKZUuRLwNEiBDQ8aZ%2BNfQ@mail.gmail.com>
In-Reply-To: <202203291244.22TCiupK014470@gitrepo.freebsd.org>
References:  <202203291244.22TCiupK014470@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000000269e905db5b8ea9
Content-Type: text/plain; charset="UTF-8"

On Tue, Mar 29, 2022 at 8:45 PM Adriaan de Groot <adridg@freebsd.org> wrote:

> The branch main has been updated by adridg:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=b71f7e3faa7181387717df55cfd009db723b3d71
>
> commit b71f7e3faa7181387717df55cfd009db723b3d71
> Author:     Adriaan de Groot <adridg@FreeBSD.org>
> AuthorDate: 2022-03-28 19:20:06 +0000
> Commit:     Adriaan de Groot <adridg@FreeBSD.org>
> CommitDate: 2022-03-29 12:44:53 +0000
>
>     graphics/gdal: switch to C++17 for upcoming poppler
>
>     This is a fix-it-before-it-breaks for a poppler update that requires
>     consumers (like gdal) to compile in C++17 mode.
>
>     PR:             260956
> ---
>  graphics/gdal/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/graphics/gdal/Makefile b/graphics/gdal/Makefile
> index 5cd9500a265b..9d874f096276 100644
> --- a/graphics/gdal/Makefile
> +++ b/graphics/gdal/Makefile
> @@ -2,7 +2,7 @@
>
>  PORTNAME=      gdal
>  PORTVERSION=   3.4.1
> -PORTREVISION=  8
> +PORTREVISION=  9
>  CATEGORIES=    graphics geography
>  MASTER_SITES=  https://download.osgeo.org/gdal/${PORTVERSION}/ \
>                 LOCAL/sunpoet
> @@ -42,12 +42,12 @@ PCRE2_DESC= Regular expression support for SQLite
>  RASTERLITE2_DESC=      RasterLite2 support
>  TILEDB_DESC=   TileDB support
>
> -USES=          compiler:c++14-lang cpe gmake iconv jpeg localbase
> pkgconfig ssl tar:xz
> +USES=          compiler:c++17-lang cpe gmake iconv jpeg localbase
> pkgconfig ssl tar:xz
>
>  CFLAGS+=       -fPIC
>  CONFIGURE_ARGS=        --datadir=${PREFIX}/share \
>                 --enable-static=yes \
> -               --with-cpp14 \
> +               --with-cpp17 \
>

Please revert this. There is no such argument (--with-cpp17).
Thanks.


>                 --with-crypto=yes \
>                 --with-geotiff=yes \
>                 --with-gif=yes \
> @@ -69,7 +69,7 @@ CONFIGURE_ARGS=       --datadir=${PREFIX}/share \
>  GNU_CONFIGURE= yes
>  LDFLAGS+=      ${ICONV_LIB}
>  MAKEFILE=      GNUmakefile
> -USE_CXXSTD=    c++14
> +USE_CXXSTD=    c++17
>  USE_LDCONFIG=  yes
>
>  PLIST_SUB=     PORTVERSION=${PORTVERSION}
>
>

--0000000000000269e905db5b8ea9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Tue, Mar 29, 2022 at 8:45 PM Adriaan d=
e Groot &lt;<a href=3D"mailto:adridg@freebsd.org" target=3D"_blank">adridg@=
freebsd.org</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex">The branch main has been updated by a=
dridg:<br>
<br>
URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3Db71f7e3faa71813=
87717df55cfd009db723b3d71" rel=3D"noreferrer" target=3D"_blank">https://cgi=
t.FreeBSD.org/ports/commit/?id=3Db71f7e3faa7181387717df55cfd009db723b3d71</=
a><br>
<br>
commit b71f7e3faa7181387717df55cfd009db723b3d71<br>
Author:=C2=A0 =C2=A0 =C2=A0Adriaan de Groot &lt;adridg@FreeBSD.org&gt;<br>
AuthorDate: 2022-03-28 19:20:06 +0000<br>
Commit:=C2=A0 =C2=A0 =C2=A0Adriaan de Groot &lt;adridg@FreeBSD.org&gt;<br>
CommitDate: 2022-03-29 12:44:53 +0000<br>
<br>
=C2=A0 =C2=A0 graphics/gdal: switch to C++17 for upcoming poppler<br>
<br>
=C2=A0 =C2=A0 This is a fix-it-before-it-breaks for a poppler update that r=
equires<br>
=C2=A0 =C2=A0 consumers (like gdal) to compile in C++17 mode.<br>
<br>
=C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0260956<br>
---<br>
=C2=A0graphics/gdal/Makefile | 8 ++++----<br>
=C2=A01 file changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/graphics/gdal/Makefile b/graphics/gdal/Makefile<br>
index 5cd9500a265b..9d874f096276 100644<br>
--- a/graphics/gdal/Makefile<br>
+++ b/graphics/gdal/Makefile<br>
@@ -2,7 +2,7 @@<br>
<br>
=C2=A0PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 gdal<br>
=C2=A0PORTVERSION=3D=C2=A0 =C2=A03.4.1<br>
-PORTREVISION=3D=C2=A0 8<br>
+PORTREVISION=3D=C2=A0 9<br>
=C2=A0CATEGORIES=3D=C2=A0 =C2=A0 graphics geography<br>
=C2=A0MASTER_SITES=3D=C2=A0 <a href=3D"https://download.osgeo.org/gdal/$%7B=
PORTVERSION%7D/" rel=3D"noreferrer" target=3D"_blank">https://download.osge=
o.org/gdal/${PORTVERSION}/</a> \<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 LOCAL/sunpoet<br>
@@ -42,12 +42,12 @@ PCRE2_DESC=3D Regular expression support for SQLite<br>
=C2=A0RASTERLITE2_DESC=3D=C2=A0 =C2=A0 =C2=A0 RasterLite2 support<br>
=C2=A0TILEDB_DESC=3D=C2=A0 =C2=A0TileDB support<br>
<br>
-USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler:c++14-lang cpe gmake ic=
onv jpeg localbase pkgconfig ssl tar:xz<br>
+USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler:c++17-lang cpe gmake ic=
onv jpeg localbase pkgconfig ssl tar:xz<br>
<br>
=C2=A0CFLAGS+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0-fPIC<br>
=C2=A0CONFIGURE_ARGS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 --datadir=3D${PREFIX}/sh=
are \<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --enable-static=3Dy=
es \<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--with-cpp14 \<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--with-cpp17 \<br><=
/blockquote><div><br></div><div>Please revert this. There is no such argume=
nt (--with-cpp17).</div><div>Thanks.</div><div>=C2=A0</div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r=
gb(204,204,204);padding-left:1ex">
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --with-crypto=3Dyes=
 \<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --with-geotiff=3Dye=
s \<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --with-gif=3Dyes \<=
br>
@@ -69,7 +69,7 @@ CONFIGURE_ARGS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0--datadir=3D$=
{PREFIX}/share \<br>
=C2=A0GNU_CONFIGURE=3D yes<br>
=C2=A0LDFLAGS+=3D=C2=A0 =C2=A0 =C2=A0 ${ICONV_LIB}<br>
=C2=A0MAKEFILE=3D=C2=A0 =C2=A0 =C2=A0 GNUmakefile<br>
-USE_CXXSTD=3D=C2=A0 =C2=A0 c++14<br>
+USE_CXXSTD=3D=C2=A0 =C2=A0 c++17<br>
=C2=A0USE_LDCONFIG=3D=C2=A0 yes<br>
<br>
=C2=A0PLIST_SUB=3D=C2=A0 =C2=A0 =C2=A0PORTVERSION=3D${PORTVERSION}<br>
<br>
</blockquote></div></div>

--0000000000000269e905db5b8ea9--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58S4G1bzq58VYv8GSuwh8t7%2BOyKZUuRLwNEiBDQ8aZ%2BNfQ>