From owner-freebsd-hackers@FreeBSD.ORG  Mon Nov 22 18:35:23 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id AB5AA10656DE; Mon, 22 Nov 2010 18:35:23 +0000 (UTC)
Date: Mon, 22 Nov 2010 18:35:23 +0000
From: Alexander Best <arundel@freebsd.org>
To: Bruce Cran <bruce@cran.org.uk>
Message-ID: <20101122183523.GA28412@freebsd.org>
References: <20101122162712.3c3655fe@core.draftnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101122162712.3c3655fe@core.draftnet>
Cc: freebsd-hackers@freebsd.org
Subject: Re: Logical vs. bitwise AND in sbin/routed/parms.c
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Nov 2010 18:35:23 -0000

On Mon Nov 22 10, Bruce Cran wrote:
> I've been going through src/bin and src/sbin seeing how easy it would
> be to remove warnings clang generates. During the work I came
> across routed/parms.c which appears to be doing a logical instead of
> bitwise AND. Would the following change be correct?

looking good. i also found some occurences of logical AND, although bitwise
AND would have been better. the changes got committed in [1].

cheers.
alex

[1] http://svn.freebsd.org/changeset/base/213318

> 
> Index: /usr/src/head/sbin/routed/parms.c
> ===================================================================
> --- /usr/src/head/sbin/routed/parms.c   (revision 215671)
> +++ /usr/src/head/sbin/routed/parms.c   (working copy)
> @@ -876,11 +876,11 @@
>                 if ((0 != (new->parm_int_state & GROUP_IS_SOL_OUT)
>                      && 0 != (parmp->parm_int_state & GROUP_IS_SOL_OUT)
>                      && 0 != ((new->parm_int_state ^
> parmp->parm_int_state)
> -                             && GROUP_IS_SOL_OUT))
> +                             & GROUP_IS_SOL_OUT))
>                     || (0 != (new->parm_int_state & GROUP_IS_ADV_OUT)
>                         && 0 != (parmp->parm_int_state &
> GROUP_IS_ADV_OUT) && 0 != ((new->parm_int_state ^ parmp->parm_int_state)
> -                                && GROUP_IS_ADV_OUT))
> +                                & GROUP_IS_ADV_OUT))
>                     || (new->parm_rdisc_pref != 0
>                         && parmp->parm_rdisc_pref != 0
>                         && new->parm_rdisc_pref !=
>                         parmp->parm_rdisc_pref)
> 
> -- 
> Bruce Cran

-- 
a13x