From owner-freebsd-bugs@FreeBSD.ORG  Tue Feb 14 20:30:11 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1AF5E1065677
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 14 Feb 2012 20:30:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D1E148FC13
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 14 Feb 2012 20:30:10 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q1EKUAZQ095406
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 14 Feb 2012 20:30:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q1EKUAYh095403;
	Tue, 14 Feb 2012 20:30:10 GMT (envelope-from gnats)
Resent-Date: Tue, 14 Feb 2012 20:30:10 GMT
Resent-Message-Id: <201202142030.q1EKUAYh095403@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Eugen Konkov <kes-kes@yandex.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 88BDE106566B
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 14 Feb 2012 20:27:40 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 78A658FC16
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 14 Feb 2012 20:27:40 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q1EKRdKg013888
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Feb 2012 20:27:39 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q1EKRdlu013887;
	Tue, 14 Feb 2012 20:27:39 GMT (envelope-from nobody)
Message-Id: <201202142027.q1EKRdlu013887@red.freebsd.org>
Date: Tue, 14 Feb 2012 20:27:39 GMT
From: Eugen Konkov <kes-kes@yandex.ru>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/165153: wrong de optimization
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Feb 2012 20:30:11 -0000


>Number:         165153
>Category:       misc
>Synopsis:       wrong de optimization
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 14 20:30:10 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Eugen Konkov
>Release:        10.0-CURRENT
>Organization:
ISP FreeLine
>Environment:
>Description:
you must revert commit 231585 because of next:
there were
	/*
	 * Microoptimisations for a ng_socket with no
	 * hooks, or with a single hook, which is a
	 * common case.
	 */
which says that if node has no hooks DO NOTHING
	if (node->nd_numhooks == 0)
		return (NULL);

in r231585 there is no such check so for node with no hooks there were useless timespend in FOREACH loop. instead of fast 'return (NULL)' as it were before
>How-To-Repeat:

>Fix:
revert 231585 

>Release-Note:
>Audit-Trail:
>Unformatted: