From nobody Tue Jul 28 08:41:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h8TT24HxDz6mMM4; Tue, 28 Jul 2026 08:41:10 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h8TT22JQSz3LC1; Tue, 28 Jul 2026 08:41:10 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785228070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OugLcT4naFR/mAMynD7zI24vy2RguQK4RTJWnJ9V7hU=; b=t/SVjTAzQfaFhsoRMne559X21zYt0k6LNESnhmCp91ZqtjRv+Zvno2xxTv0mu1ReuWQBog 8+aXHOX/0CIKg9JBRgZdWur20ZF1Tb0RdGJaGipYpNeZexx56duF2kdk2Wt9RqQO/KQyS1 q8n2lHCSYnqO74cXqiRZtSFkOGLDMif6Bz+wa/MyuAucjZdn/EzYJhcN027dAgMo/0eL9r SuAbOcny613VeDpkwRANh7KrHkMo+RxoEYj3lsDe9oEtkgGQvx0+qhIsI4mEGRrFEQZq6Z kU4jK8XBtF0iVlEnFgIBtoxMyv6Iv7bKvYMsP6rq/F0NJi6thsS0tGAcfMbgfA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785228070; a=rsa-sha256; cv=none; b=gL/phPUgLdeWTWvY4sNll1Ieqa9Qhx8udjn2wTKQ3X2Uh4ZR7iARsWfWlYuogdRLKimoK3 dk4rX3QfblcGgBeTrUG6uJG5o3SutxlPXJzWmjlDaRV0o4qPUzNM6Auax6fr6AodoLrTJo 5ydHL5ULvaVaDeujBhTANbm1RZmcY3BHE42+mp3b2oMiiqZtU8CKXyUPKVSy+EbVPhkE10 tSztDcNG3Sv1Vj8q763Fvft/Z0KTrFrovLNjbKz+GZj8OY1cJko/TboeadbHcq4ODAYAZ8 nEwEyEuA1nYmU7zCScu7yJLfzG2Eg3ZDJOoU5AeauEFtEqxKsD+sPtihFexU3w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785228070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OugLcT4naFR/mAMynD7zI24vy2RguQK4RTJWnJ9V7hU=; b=oxJqwqIipDT/V0F1dpWy9gprzgprjyrGf4aY7034OS5tbB6XJ8Vey7aGiRkUFl3oPccXMD wwutPKAkS0vpb1RLB20cixMchX7zcYVT1c3JEEqN3RzmHOZWOY8L+KY9U1Do/zgmjvr5wm iUydYsbxSK89mVU0l47vkjO1g9yTS0OV3KE/kug+ceNtFfPqFF4AK2z4ynm0yKy58vzLN+ JNKnqvZF63n+jQtvIlril9HCA+b4TM/uIZB0hoddH7B5m9eTG9pa2aCbF/66usA+oyKiAS wOA9AzwWLYtl8RV6c0zisw70t1xvWV8v0q/Ji+JM3khkpDq4ZdxF/GVK3OxsZg== Received: from ltc.des.dev (92-129-202-201.ftth.fr.orangecustomers.net [92.129.202.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4h8TT2030bzCq; Tue, 28 Jul 2026 08:41:09 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id C12C49F078; Tue, 28 Jul 2026 10:41:08 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Mark Johnston Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: b02e02958dad - main - libfetch: Fix handling of connection failures In-Reply-To: <6a67e584.32768.6fc20c11@gitrepo.freebsd.org> (Mark Johnston's message of "Mon, 27 Jul 2026 23:11:00 +0000") References: <6a67e584.32768.6fc20c11@gitrepo.freebsd.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Tue, 28 Jul 2026 10:41:08 +0200 Message-ID: <86h5ljtskb.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mark Johnston writes: > libfetch: Fix handling of connection failures >=20=20=20=20=20 > After commit 848f360c8f9a, if one tries to connect to a closed port, > fetch reports "Operation now in progress", which is rather confusing. > Return a more useful error message, restoring the old behaviour. In hindsight this is still imperfect as it maps all connection failures to ECONNREFUSED. Is there a way to collect the correct error code, e.g. by attempting a dummy write to the socket after receiving POLLHUP, or will that just return EPIPE? (it also leaks the socket descriptor, I should have noticed in review) DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org