From owner-freebsd-firewire@FreeBSD.ORG  Mon Apr 21 19:34:37 2003
Return-Path: <owner-freebsd-firewire@FreeBSD.ORG>
Delivered-To: freebsd-firewire@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A28B237B401
	for <freebsd-firewire@freebsd.org>;
	Mon, 21 Apr 2003 19:34:37 -0700 (PDT)
Received: from is2.mh.itc.u-tokyo.ac.jp (is2.mh.itc.u-tokyo.ac.jp
	[133.11.205.12])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4F86543FE1
	for <freebsd-firewire@freebsd.org>;
	Mon, 21 Apr 2003 19:34:36 -0700 (PDT)
	(envelope-from simokawa@sat.t.u-tokyo.ac.jp)
Received: from is2.mh.itc.u-tokyo.ac.jp (is2.mh.itc.u-tokyo.ac.jp [127.0.0.1])
	by is2.mh.itc.u-tokyo.ac.jp (Postfix) with ESMTP id 37C7337806C
	for <freebsd-firewire@freebsd.org>;
	Tue, 22 Apr 2003 11:34:35 +0900 (JST)
Received: from mailhosting.itc.u-tokyo.ac.jp
	(IDENT:mirapoint@mailhosting.itc.u-tokyo.ac.jp [133.11.205.3])
	h3M2YZcV017226;	Tue, 22 Apr 2003 11:34:35 +0900
Received: from ett.sat.t.u-tokyo.ac.jp (ett.sat.t.u-tokyo.ac.jp
	[133.11.135.3])2.9.3.2)	with ESMTP id AIK64613;
	Tue, 22 Apr 2003 11:34:34 +0900 (JST)
Date: Tue, 22 Apr 2003 11:34:34 +0900
Message-ID: <ybsn0ij1cqt.wl@ett.sat.t.u-tokyo.ac.jp>
From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp>
To: Buzz Slye <buzz@gaia.arc.nasa.gov>
In-Reply-To: <Pine.GSO.4.55.0304211257370.7300@mono.arc.nasa.gov>
References: <Pine.GSO.4.55.0304211257370.7300@mono.arc.nasa.gov>
User-Agent: Wanderlust/2.11.0 (Wonderwall) REMI/1.14.3 (Matsudai)
 FLIM/1.14.3 (=?ISO-8859-1?Q?Unebigory=F2mae?=) APEL/10.3 MULE XEmacs/21.4
 (patch 8) (Honest Recruiter) (i386--freebsd)
X-Face: OE([KxWyJI0r[R~S/>7ia}SJ)i%a,$-9%7{*yihQk|]gl}2p#"oXmX/fT}Bn7:
 #j7i14gu$jgR\S*&C3R/pJX<mI-4Z8'mqt1R'CjWdw-xqVoilv`\JgZcquM5oV
 uO^<vt/~051rCDM(`{rM~?{Okr,XC+}Ycm9IJO)odT*-0nyJjBJYzL{GsZ
MIME-Version: 1.0 (generated by REMI 1.14.3 - "Matsudai")
Content-Type: text/plain; charset=US-ASCII
cc: freebsd-firewire@freebsd.org
Subject: Re: Bug Report
X-BeenThere: freebsd-firewire@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Vendors pre-release coordination <freebsd-firewire.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>,
	<mailto:freebsd-firewire-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-firewire>
List-Post: <mailto:freebsd-firewire@freebsd.org>
List-Help: <mailto:freebsd-firewire-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>,
	<mailto:freebsd-firewire-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Apr 2003 02:34:37 -0000

At Mon, 21 Apr 2003 12:58:34 -0700 (PDT),
Buzz Slye wrote:
> 
> In module fwdev.c, the following code -
..
> 			xfer->dst = fwdev->dst;
> 			fp->mode.hdr.dst = htons(FWLOCALBUS | xfer->dst);
...

> 			xfer->dst = FWLOCALBUS | fwdev->dst;
> 			fp->mode.hdr.dst = htons(xfer->dst);

Thanks, committed.

Please note because latest code uses the natural endian for packet
headers, we don't need htons() anymore.

/\ Hidetoshi Shimokawa
\/  simokawa@sat.t.u-tokyo.ac.jp
PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html