Date: Tue, 03 Feb 2015 11:00:49 +0100 From: John Marino <freebsd.contact@marino.st> To: Tijl Coosemans <tijl@FreeBSD.org>, Kubilay Kocak <koobs@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r378316 - head/devel/libhtp Message-ID: <54D09C51.5020001@marino.st> In-Reply-To: <20150203105553.3bbbeb6c@kalimero.tijl.coosemans.org> References: <201502021841.t12IfvP1021156@svn.freebsd.org> <54D01223.7020703@FreeBSD.org> <54D015B7.2080408@marino.st> <54D01B67.4010406@FreeBSD.org> <20150203105553.3bbbeb6c@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/3/2015 10:55, Tijl Coosemans wrote: > On Tue, 03 Feb 2015 11:50:47 +1100 Kubilay Kocak <koobs@FreeBSD.org> wrote: >> On 3/02/2015 11:26 AM, John Marino wrote: >>> I don't know if "LIBS" is standardized but it's a flag that's missing, >>> not a library. >> >> I'll pull tijl@ in the explain this one if needed and I'll leave this >> commit reference here as well: >> >> https://svnweb.freebsd.org/ports?view=revision&revision=357486 > > Both -L and -l should go into LIBS if possible. LIBS appears later on > the command line and -L${LOCALBASE}/lib should appear after any -L flags > specified by upstream. > >> And just to note, there was this related and "simple" change that broke >> Python completely: >> >> https://lists.freebsd.org/pipermail/freebsd-python/2014-July/007129.html > > I think you misremember this. It turned out to be a misconfiguration in > the user's make.conf. > >>>> Further, if it is indeed the case that iconv:translit adds -liconv to >>>> LDFLAGS, wouldn't adding -L${LOCALBASE}/lib to LDFLAGS be better solved >>>> in Uses/iconv.mk when that case is true? >>> >>> I would think so. >>> Most of the time this doesn't pop up because another dependency brings >>> in -L/usr/local/lib so it works by accident very often. >>> >>> At the very least it should have an ${LDFLAGS_ICONV} option that could >>> be added to LDFLAGS. It would be a more correct solution. >> >> If you can sort out a proper fix in the right place that would be great. >> You have approval from me to revert/change devel/libhtp as necessary. > > You can use -L${ICONV_PREFIX}/lib (and -I${ICONV_PREFIX}/include). The > reason USES=iconv doesn't add -L/-l to LDFLAGS or LIBS (or -I to > CPPFLAGS) is because not all ports support these variables and the > ordering of the flags may be important. Only the port Makefile knows > all the flags that need to be added and in which order. Okay, so to summarize: 1) it was correct to add the fix to the port makefile 2) Uses/iconv.mk doesn't have to be updated 3) I'll test moving the -L flag into LIBS, and if it still builds fine I'll make the change (I don't think it makes much difference in this case, but it seems to be preferred). Thanks tijl, John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54D09C51.5020001>