From nobody Sun Jul 19 09:40:05 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h2zCL3mXbz6lxqm; Sun, 19 Jul 2026 09:40:14 +0000 (UTC) (envelope-from fuz@fuz.su) Received: from fuz.su (fuz.su [IPv6:2001:41d0:8:e508::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "fuz.su", Issuer "fuz.su" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h2zCK4nDJz3Dpj; Sun, 19 Jul 2026 09:40:13 +0000 (UTC) (envelope-from fuz@fuz.su) Authentication-Results: mx1.freebsd.org; none Received: from fuz.su (localhost [127.0.0.1]) by fuz.su (8.18.1/8.18.1) with ESMTPS id 66J9e6P2015413 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 19 Jul 2026 11:40:06 +0200 (CEST) (envelope-from fuz@fuz.su) Received: (from fuz@localhost) by fuz.su (8.18.1/8.18.1/Submit) id 66J9e6va015412; Sun, 19 Jul 2026 11:40:06 +0200 (CEST) (envelope-from fuz) Date: Sun, 19 Jul 2026 11:40:05 +0200 From: Robert Clausecker To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Cc: Gleb Smirnoff , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 77a201b1705d - main - ministat: parse comma used as decimal delimiter Message-ID: References: <6a5987fe.3e18c.5660ceff@gitrepo.freebsd.org> <86zeznz6hp.fsf@ltc.des.dev> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86zeznz6hp.fsf@ltc.des.dev> X-Rspamd-Queue-Id: 4h2zCK4nDJz3Dpj X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR] X-Spamd-Bar: ---- I agree. Either adapt the parser to be locale aware (see localeconv(3)) or document that tools must be run in the C locale. But don't try to play Pokémon with separators. It'll blow up horribly. Please revert. Yours, Robert Clausecker Am Sun, Jul 19, 2026 at 11:14:10AM +0200 schrieb Dag-Erling Smørgrav: > Gleb Smirnoff writes: > > commit 77a201b1705dbd97ea9ebe5b25b1d4ddac8a7d38 > > Author: Gleb Smirnoff > > AuthorDate: 2026-07-17 00:49:55 +0000 > > Commit: Gleb Smirnoff > > CommitDate: 2026-07-17 01:40:03 +0000 > > > > ministat: parse comma used as decimal delimiter > > > > This allows to use output of '/usr/bin/time -ao foo' as direct input to > > ministat(1). > > > > While here make diagnostic message more verbose. > > This is wrong. What if delim is ","? The correct solution is to either > run your time command with LANG=C, or post-process the output. > > DES > -- > Dag-Erling Smørgrav - des@FreeBSD.org > > -- () ascii ribbon campaign - for an encoding-agnostic world /\ - against html email - against proprietary attachments