From owner-cvs-sys  Mon Aug 28 02:58:00 1995
Return-Path: cvs-sys-owner
Received: (from majordom@localhost)
          by freefall.FreeBSD.org (8.6.11/8.6.6) id CAA17660
          for cvs-sys-outgoing; Mon, 28 Aug 1995 02:58:00 -0700
Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241])
          by freefall.FreeBSD.org (8.6.11/8.6.6) with ESMTP id CAA17611
          ; Mon, 28 Aug 1995 02:56:28 -0700
Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id CAA00624; Mon, 28 Aug 1995 02:56:18 -0700
From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
Message-Id: <199508280956.CAA00624@gndrsh.aac.dev.com>
Subject: Re: cvs commit: src/sys/vm vm_extern.h vm_glue.c vm_init.c vm_pageout.c vm_pageout.h
To: julian@freefall.FreeBSD.org (Julian Elischer)
Date: Mon, 28 Aug 1995 02:56:18 -0700 (PDT)
Cc: CVS-commiters@freefall.FreeBSD.org, cvs-sys@freefall.FreeBSD.org
In-Reply-To: <199508280919.CAA15088@freefall.FreeBSD.org> from "Julian Elischer" at Aug 28, 95 02:19:27 am
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 2536      
Sender: cvs-sys-owner@FreeBSD.org
Precedence: bulk

> 
> julian      95/08/28 02:19:26
> 
>   Modified:    sys/i386/i386  autoconf.c machdep.c
>                sys/i386/ibcs2  ibcs2_stats.c imgact_coff.c
>                sys/i386/linux  linux_stats.c
>                sys/kern  init_main.c kern_clock.c kern_malloc.c
>                         kern_synch.c  subr_prof.c sysv_msg.c sysv_sem.c
>                         sysv_shm.c tty_subr.c  uipc_domain.c uipc_mbuf.c
>                         vfs_bio.c vfs_conf.c vfs_init.c  vfs_syscalls.c
>                sys/net   if.c
>                sys/sys   kernel.h mount.h namei.h systm.h vnioctl.h
>                sys/ufs/ffs  ffs_vfsops.c
>                sys/ufs/lfs  lfs_vfsops.c
>                sys/ufs/mfs  mfs_extern.h mfs_vfsops.c
>                sys/ufs/ufs  dir.h ufs_lookup.c ufs_vnops.c
>                sys/vm    vm_extern.h vm_glue.c vm_init.c vm_pageout.c
>                         vm_pageout.h
>   Log:
>   Reviewed by:	julian with quick glances by bruce and others
>   Submitted by:	terry (terry lambert)
>   This is  a composite of 3 patch sets submitted by terry.
>   they are:
>   New low-level init code that supports loadbal modules better
>   some cleanups in the namei code to help terry in 16-bit character support
>   some changes to the mount-root code to make it a little more
>   modular..

Please, for the future do that as 3 commits.  It makes it easier to figure
out which changes do what using cvs.  Now these are all mixed into one
commit and seperating deltas for examination is a pain.  It also makes
it next to imposible to pull just one of these 3 into another branch
for evaluation.

>   NOTE: mounting root off cdrom or NFS MIGHT be broken as I haven't been able
>   to test those cases..

Loss of root mounting via NFS is a critical function for diskless operation,
this should have been tested before commit :-(.

>   certainly mounting root of disk still works just fine..
>   mfs should work but is untested. (tomorrows task)

Again, mfs root is critical to installs, should have been tested before
commit, not after.

>   The low level init stuff includes a total rewrite of init_main.c
>   to make it possible for new modules to have an init phase by simply
>   adding an entry to a TEXT_SET (or is it DATA_SET) list. thus a new module can
>   be added to the kernel without editing any other files other than the
>   'files' file.

YEA!!!


-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                 Reliable computers for FreeBSD