Date: Thu, 15 Jul 2010 22:04:19 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Jung-uk Kim <jkim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r210005 - head/sys/modules/acpi/acpi Message-ID: <20100715220012.X1719@delplex.bde.org> In-Reply-To: <201007131657.o6DGvq9L097594@svn.freebsd.org> References: <201007131657.o6DGvq9L097594@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 13 Jul 2010, Jung-uk Kim wrote: > Log: > Define SMP unconditionally for amd64 and remove opt_global.h from SRCS. > Note it is done just for correctness sake because we do not build, ship, or > support acpi.ko on amd64. > > Prodded by: bde Thanks. It was much more interesting than I noticed. Modules are supposed to be independent of all configuration options, especially global ones, especially especially SMP. Perhaps this is too much to ask for acpi. Does it work now, after you removed an SMP ifdef from it? Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100715220012.X1719>