From owner-freebsd-ports-bugs@freebsd.org Tue Apr 28 09:55:16 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 346822B3A06 for ; Tue, 28 Apr 2020 09:55:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 49BH7m0hvRz4WJ1 for ; Tue, 28 Apr 2020 09:55:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 160712B3A05; Tue, 28 Apr 2020 09:55:16 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 15D1D2B3A04 for ; Tue, 28 Apr 2020 09:55:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49BH7l6Txkz4WHy for ; Tue, 28 Apr 2020 09:55:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D559E2253C for ; Tue, 28 Apr 2020 09:55:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 03S9tFHr072014 for ; Tue, 28 Apr 2020 09:55:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 03S9tFb4072013 for ports-bugs@FreeBSD.org; Tue, 28 Apr 2020 09:55:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 245997] emulators/qemu emulators/qemu-devel sysutils/dtc devel/valgrind [patch] use system dtc in qemu builds + additional updates Date: Tue, 28 Apr 2020 09:55:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lab+bsd@thinkum.space X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2020 09:55:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245997 Bug ID: 245997 Summary: emulators/qemu emulators/qemu-devel sysutils/dtc devel/valgrind [patch] use system dtc in qemu builds + additional updates Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: lab+bsd@thinkum.space CC: bofh@freebsd.org CC: bofh@freebsd.org Created attachment 213883 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D213883&action= =3Dedit Patch for emulators/qemu emulators/qemu-devel sysutils/dtc devel/valgrind In synopsis: When building devel/qemu under poudriere, on a FreeBSD 12.1 am= d64 machine I was encountering a persistent build failure with devel/qemu during staging - an excerpt from the build log ~~~~ mkdir: dtc/libfdt/libfdt.h: File exists gmake[1]: *** [Makefile:488: dtc/libfdt/libfdt.h] Error 1 gmake[1]: Leaving directory '/wrkdirs/usr/ports/emulators/qemu/work/qemu-4.= 1.1' ~~~~ After taking a look at the qemu configure script, I discovered that it may = be possible to build with an existing libfdt.so. In order to do so, I've had to update sysutils/dtc to version 1.6.0, as well as updating how the extra ldf= lags are provided to the qemu configure script. The qemu build now succeeds, locally. The additional testing now available = for sysutils/dtc also succeeds under make(test). For purpose of usability, I've made some additional changes in the update - as detailed, in the following. Summary of changes: devel/valgrind: Update vki-freebsd.h patch for changes recommended in http://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239669 emulators/qemu-devel: Add dtc dependency; move debug support into a DEBUG port option, also setting WITH_DEBUG in this situation, enabling the option by default; allow build with ncurses from ports, similar to the emulators/qemu port; Upate how extra-ldflags are provided to the configure script - providing the value only once, with no quote marks, to ensure that the system dtc is detected during configure emulators/qemu: Update in parallel to emulator/qemu for dtc from ports and debug support sysutils/dtc: Update to upstream release 1.6.0 - in which, the function fdt_check_full() is now defined differently, to a side effect as that the function should not be stripped from libfdt.so during normal pkg staging. The function is used during qemu configure, for detecting the presence of a system dtc. Add port option for building with yaml support for dtc (not enabled by default); Add port option for valgrind support during make(test), for amd64, i386 architectures; Add post-patch hacks for ensuring that the build will not fail when yaml.h and valgrind/memcheck.h cannot be located under wrksrc - these were being added to make dependencies under generated *.d files, in local build, should otherwise be unused in the build; Add subst vars for port version in distinfo, as a convenience for port maint. --=20 You are receiving this mail because: You are the assignee for the bug.=