From owner-cvs-all Tue Sep 17 2:35:12 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB8A537B406; Tue, 17 Sep 2002 02:35:10 -0700 (PDT) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9C1843E42; Tue, 17 Sep 2002 02:35:09 -0700 (PDT) (envelope-from dl-freebsd@catspoiler.org) Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.12.5/8.12.5) with ESMTP id g8H9Vvwr015410; Tue, 17 Sep 2002 02:32:01 -0700 (PDT) (envelope-from dl-freebsd@catspoiler.org) Message-Id: <200209170932.g8H9Vvwr015410@gw.catspoiler.org> Date: Tue, 17 Sep 2002 02:31:57 -0700 (PDT) From: Don Lewis Subject: Re: cvs commit: src/sys/kern kern_timeout.c To: brandt@fokus.gmd.de Cc: dl-freebsd@catspoiler.org, phk@critter.freebsd.dk, archie@dellroad.org, bde@zeta.org.au, joe@FreeBSD.org, obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <20020917111410.U812-100000@beagle.fokus.gmd.de> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 17 Sep, Harti Brandt wrote: > On Tue, 17 Sep 2002, Don Lewis wrote: > > DL>On 17 Sep, Harti Brandt wrote: > DL>> (2) two macros MII_SET and MII_CLR are used to fiddle with the MDIO bits. > DL>> This looks fine from an aesthetic standpoint of view, but adds some dozens > DL>> of additional operations. I introduced a MII_SETCLR macro which can set > DL>> and clear bits at the same time. This reduces the readreg time further to > DL>> 250usecs. > DL> > DL>There is a problem here. The 802.3 spec says that MDIO may not change > DL>within 10ns of the rising edge of the clock. Even if the card doesn't > DL>require strict adherence to the 802.3 timing, I'd expect that changing > DL>both at the same time would be hazardous. > > In the place where the macro is used, it clears the clock bit and sets the > data bit, so this is the falling edge of the clock, which should be ok. Ok. I had reversed the order of the arguments to the macro when I read the patch the first time. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message