Date: Thu, 18 Dec 2014 20:33:08 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 196108] New: Fix emulators/open-vm-tools(-nox11) build with clang 3.5.0 Message-ID: <bug-196108-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196108 Bug ID: 196108 Summary: Fix emulators/open-vm-tools(-nox11) build with clang 3.5.0 Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: swills@FreeBSD.org Reporter: dim@FreeBSD.org Flags: maintainer-feedback?(swills@FreeBSD.org) Assignee: swills@FreeBSD.org Created attachment 150735 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=150735&action=edit Fix emulators/open-vm-tools(-nox11) build with clang 3.5.0 The emulators/open-vm-tools and its -nox11 variant ports fail to compile with clang 3.5.0, due to the following -Werror warning: toolboxcmd-shrink.c:394:31: error: comparison of constant 'WIPER_ENABLED' (2) with boolean expression is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (!ShrinkGetWiperState() == WIPER_ENABLED && !Wiper_IsWipeSupported(part)) { ~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~ 1 error generated. This is a logic error in the code, the ! operator applies to the left hand part of the == expression, while WIPER_ENABLED is one of three possible enum values. The code should use "ShrinkGetWiperState() != WIPER_ENABLED" instead. --- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> --- Auto-assigned to maintainer swills@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-196108-13>