From owner-svn-src-head@freebsd.org Thu May 21 02:41:11 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F19CC2FDD38 for ; Thu, 21 May 2020 02:41:11 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from 44-233-67-66-mail.ore.mailhop.org (44-233-67-66-mail.ore.mailhop.org [44.233.67.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49SDQH16hVz4CT4 for ; Thu, 21 May 2020 02:41:10 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1590028869; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=lTH1KJJCtGnVFSKqjmchBMRGR57l7imJ2cr3o+rnj6yRg0O2YiStGL0gkzBbWbdSRBFHl+qBIogqb T4dNBkQZU0rMg00M5MPbqAglzRgJSTkxsUIvaT3YP0dDgoiANWeBOK9UvAu0qvDDWs/sflQ9Pvx0Yx s5Q9top+pGEz08tGk83pecQnf512U1U1ei54VNL3ADj90pfIY9YXlG1AcVSjPu1PHdXClswP7MdPHg iE9FExIb7e3E0SZz4fmnG2+3sioYOMk9Xlpj6S9GWmMCPpjRH5PNfOy8+gk682LVbyRSbu2ZtHdLem T1m4pRUnUicw74cJis9qzZkmbdY5gbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=1wC2H0fjTO3DY0a+2GROUANMyTkiFDLBaaxbHlHRf44=; b=muZuUAublVDNfjBRgpeeO1nPRcZ783BuQS7lsNz5/KggdW+OauVvXy3EajKZO+agpRB7pwKMF23DM D1+73qRz/t6sRZfbDFteHPt55mjwSGky4zaAF6GrG0dm8XuLGLTZwG3On4BR6UkVDOt1hwoGhQwWiL lxM63AJq9gBKqs65526fMIlK0giivGsqKWjKnhVJzKITJKNEgLX7PLysaqaaU+SZhzn2egUoxkGfXg vPa4eACoDR11JmnWseo2ZVohp+dzFF9ABaa2o+FmwM3Q6CEjUnt4nox8PY+nlIH8fUcQK9xkcWikPu UCln4d8tvjXaiWo+bBVMBTdljcvms/A== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=1wC2H0fjTO3DY0a+2GROUANMyTkiFDLBaaxbHlHRf44=; b=cqXuLDDQIDTUeTSEGgAoJgFf5oDyWY8v1PopdxiyiaRGxLrtubuCRLNPxior++CoHMQ2OJjfJvx/i IhnpBZuYqv7AmVlyIBQfuvI2YpKMFq97vs6yxUOFKRYfIbV2xxLiRS6QtAguUaFYavGC3DARHuItdl vXD3U11bFC+vHRCQqm7voCnnJZqbtpTTUreAduuM0gwyks2m6syU1WYxcUo0JtFXPVSzJ2Lzzlotv0 vqbl7Hyfy4lfBJE+CUIG7VsEcA+fKybOT7N9gSN+aKrWn7vr3WMvZiUPbHIP4XldzLmTZP+ShpG6o5 w7MB4unh+3e2hABBzsxQ8UpZLeV49nA== X-MHO-RoutePath: aGlwcGll X-MHO-User: 851979c5-9b0c-11ea-b10c-b5956a7dd1a1 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 851979c5-9b0c-11ea-b10c-b5956a7dd1a1; Thu, 21 May 2020 02:41:08 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 04L2f5K5012589; Wed, 20 May 2020 20:41:06 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <761b75a4ad0a4630bce26aad1b03137ac45509fd.camel@freebsd.org> Subject: Re: svn commit: r361275 - in head/sys: conf dev/hyperv/hvsock dev/hyperv/include dev/hyperv/vmbus modules/hyperv modules/hyperv/hvsock sys From: Ian Lepore To: Wei Hu , Enji Cooper , Shawn Webb Cc: Wei Hu , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Date: Wed, 20 May 2020 20:41:05 -0600 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 49SDQH16hVz4CT4 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:16509, ipnet:44.224.0.0/11, country:US]; local_wl_from(0.00)[freebsd.org] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2020 02:41:12 -0000 On Thu, 2020-05-21 at 01:53 +0000, Wei Hu wrote: > > -----Original Message----- > > From: Enji Cooper > > Sent: Wednesday, May 20, 2020 11:58 PM > > To: Shawn Webb > > Cc: Wei Hu ; src-committers@freebsd.org; svn-src- > > all@freebsd.org; svn-src-head@freebsd.org > > Subject: Re: svn commit: r361275 - in head/sys: conf dev/hyperv/hvsock > > dev/hyperv/include dev/hyperv/vmbus modules/hyperv > > modules/hyperv/hvsock sys > > > > > > > On May 20, 2020, at 08:54, Enji Cooper wrote: > > > > > > > > On May 20, 2020, at 08:11, Shawn Webb > > > > wrote: > > > > > > > > > > On Wed, May 20, 2020 at 11:03:59AM +0000, Wei Hu wrote: > > > > > Author: whu > > > > > Date: Wed May 20 11:03:59 2020 > > > > > New Revision: 361275 > > > > > URL: > > > > > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsv > > > > > > > > > nweb.freebsd.org%2Fchangeset%2Fbase%2F361275&data=02%7C01%7C > > weh% > > > > > > > > > 40microsoft.com%7Cd6ff3617bffa43d10a7708d7fcd68470%7C72f988bf86f141 > > a > > > > > > > > > f91ab2d7cd011db47%7C1%7C0%7C637255870581110888&sdata=mzz6R > > ILCVBk > > > > > q06RI1PAfVNKWZO2y7jBO0C1E%2F%2FEJwUY%3D&reserved=0 > > > > > > > > > > Log: > > > > > HyperV socket implementation for FreeBSD > > > > > > > > > > This change adds Hyper-V socket feature in FreeBSD. New socket > > > > > address family AF_HYPERV and its kernel support are added. > > > > > > Hi Wei, > > > Could you please further describe what this feature is/does? > > > > I realize after looking at the review that it contains the content I was hoping > > for. It would have been helpful to folks if this context had been included in the > > commit message. > > Hi Enji, > > I thought I just keep it simple for the commit log message while people can > refer to the review site for details. Sorry about that. Let me know if there is > anyway to make up for it. > > Wei > Ten years from now, phabricator may just be a fading memory, but the source code repo lives forever. Usually when I put something in phab for review, the description I enter in phab is exactly the text I intend to use when committing the change. That helps the people doing the review... the description is an overview of what is being changed, and most importantly, why it is being changed (fixes a bug, adds a new feature, better performance, etc). Everything you say there to help reviewers will be equally helpful in the repo history when someone needs to research some day why a change got made. -- Ian