From nobody Thu Feb 22 09:32:44 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TgScK67JGz5CGcX; Thu, 22 Feb 2024 09:33:05 +0000 (UTC) (envelope-from makc@freebsd.org) Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.issp.ac.ru", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TgScK1Qc7z4cYL; Thu, 22 Feb 2024 09:33:05 +0000 (UTC) (envelope-from makc@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from mail-lf1-f53.google.com [209.85.167.53:56450] (HELO/EHLO mail-lf1-f53.google.com, authenticated with PLAIN) by mail.issp.ac.ru with ESMTPSA/inet id 41M9WubD049720 (using TLSv1.2, with cipher ECDHE-RSA-AES128-GCM-SHA256 (128 bits), verified FAIL) Thu, 22 Feb 2024 12:32:56 +0300 (MSK) Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-512bc0e8ce1so4879544e87.0; Thu, 22 Feb 2024 01:32:56 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXGj/QSElHIh/zFzqHWm/4vzzxjhhSZVbjl72mD2cK04N+ZrG1kt1fakHy7/KysjXalfDhpkSc8AoCMKRc1Va6mwRnI5VkEGiy6BI20Mjwq0XA7Gq8w9RW5Av9z4GOEzEBudgG/VPA3lMWdUG9oNH8OyhIzlELGP0U6eh8mBrXjjKk9qrNNoFPFsX+l23Gp4BW4nNw= X-Gm-Message-State: AOJu0YweA7CcsiHluYaM0U1Qkex6oL96/ZQpSacBRO1wTc9YYm35uM+7 yGp5+QuN4fn/N/G0WLEp+LxWIvDxKZYIL7QAS1J5T3hwvKmbtA6oMNq4AVE/gZ8uDApMCBr98yn zIUWg4X3E0bU+oiBaToXRTdIoL1s= X-Google-Smtp-Source: AGHT+IH6ZN7tlXSndQs/wUxECr3ogRhrpcI7YuzI0d3CJ23hlbhOQbV1lDS3JCFXUlJp2+nqgxkW+P2g8Y+3qBjdOQA= X-Received: by 2002:a05:6512:2246:b0:512:cbae:4e05 with SMTP id i6-20020a056512224600b00512cbae4e05mr5112780lfu.60.1708594376070; Thu, 22 Feb 2024 01:32:56 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202402211520.41LFKHJO027649@gitrepo.freebsd.org> In-Reply-To: From: Max Brazhnikov Date: Thu, 22 Feb 2024 12:32:44 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 48437516330b - main - www/nghttp2: Remove unnecessary substitution To: Nuno Teixeira Cc: Po-Chuan Hsieh , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4TgScK1Qc7z4cYL X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:9113, ipnet:77.236.32.0/20, country:RU] On Thu, 22 Feb 2024 at 11:01, Nuno Teixeira wrote: > > Hello, > > What's going on? > > -DISTVERSION= 1.59.0 > +PORTVERSION= 1.59.0 > > Should Porter's Handbook be fixed? Or veteran committers should update their knowledge :) Less jokingly, the problem with DISTVERSION/PORTVERSION is that the Porters's Handbook and ports framework are out of sync. Somebody has decided that DISTVERSION is higher than PORTVERION (makes sense for me, if you want my opinion) and has commited update to the handbook. However, the framework has not been changed, it checks for PORTVERION first, while DISTVERSION is derived from PORTVERION. If we want to switch to DISTVERSION and deprecate PORTVERSION, we should update the framework and docs and CHANGES and notify people before upcoming change and after. This applies to other changes in the ports framework. Cheers, Max