From owner-freebsd-current@FreeBSD.ORG  Sat Jan 17 15:28:29 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 043DA1065670;
	Sat, 17 Jan 2009 15:28:29 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id B9A778FC18;
	Sat, 17 Jan 2009 15:28:28 +0000 (UTC) (envelope-from des@des.no)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id EF2AE6D43F;
	Sat, 17 Jan 2009 15:28:27 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id CDBC5844C6; Sat, 17 Jan 2009 16:28:27 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Roman Divacky <rdivacky@freebsd.org>
References: <20090113215520.GA29635@freebsd.org>
	<20090113221127.GA31906@freebsd.org>
Date: Sat, 17 Jan 2009 16:28:27 +0100
In-Reply-To: <20090113221127.GA31906@freebsd.org> (Roman Divacky's message of
	"Tue, 13 Jan 2009 23:11:27 +0100")
Message-ID: <8663keymsk.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: current@freebsd.org
Subject: Re: [PATCH]: set C dialect when compiling world
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Jan 2009 15:28:29 -0000

Roman Divacky <rdivacky@freebsd.org> writes:

> On Tue, Jan 13, 2009 at 10:55:20PM +0100, Roman Divacky wrote:
>> hi
>>=20
>> in my effort to make world compile in gnu99 mode I'd like this
>> patch to be commited:
>>=20
>> Index: bsd.sys.mk
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v
>> retrieving revision 1.47
>> diff -u -r1.47 bsd.sys.mk
>> --- bsd.sys.mk	23 Jul 2008 06:14:21 -0000	1.47
>> +++ bsd.sys.mk	13 Jan 2009 21:36:04 -0000
>> @@ -8,8 +8,11 @@
>>=20=20
>>  # for GCC:  http://gcc.gnu.org/onlinedocs/gcc-3.0.4/gcc_3.html#IDX143
>>=20=20
>> -.if !defined(NO_WARNS) && ${CC} !=3D "icc"
>> -. if defined(CSTD)
>> +# the default is gnu89 for now
>> +. if !defined(CSTD)
>> +CSTD		=3D gnu89
>> +. endif
>> +
>
> CSTD	+=3D gnu89
>
> of course :)

Why "of course"?  Can you explain the expected semantics when CSTD
contains more than one word?

>> +. if !defined(CSTD)
>> +CSTD		=3D gnu89
>> +. endif

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no