From owner-svn-ports-head@freebsd.org Tue Mar 23 19:10:26 2021 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 47E4C5B8AF6; Tue, 23 Mar 2021 19:10:26 +0000 (UTC) (envelope-from joneum@FreeBSD.org) Received: from toco-domains.de (mail.toco-domains.de [176.9.100.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4F4gtT6p6dz3pZ1; Tue, 23 Mar 2021 19:10:25 +0000 (UTC) (envelope-from joneum@FreeBSD.org) Received: by toco-domains.de (Postfix, from userid 65534) id 56759123A0D; Tue, 23 Mar 2021 20:10:23 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on toco-mail X-Spam-Level: X-Spam-Status: No, score=-2.9 required=4.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.4 Received: from Jochens-MacBook-Pro.local (ip-178-202-191-19.hsi09.unitymediagroup.de [178.202.191.19]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by toco-domains.de (Postfix) with ESMTPSA id 9DE9E123A04; Tue, 23 Mar 2021 20:10:20 +0100 (CET) Subject: Re: svn commit: r569017 - head/databases/mysql57-server To: Piotr Kubaj Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202103231049.12NAnNUa027511@repo.freebsd.org> <650caf6e-5ab6-ec52-7cde-c77757a5d019@FreeBSD.org> From: Jochen Neumeister Message-ID: <501ca173-346a-11a1-581f-daa0b7e701f6@FreeBSD.org> Date: Tue, 23 Mar 2021 20:10:19 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: de-DE X-Rspamd-Queue-Id: 4F4gtT6p6dz3pZ1 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:24940, ipnet:176.9.0.0/16, country:DE]; local_wl_from(0.00)[FreeBSD.org] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 19:10:26 -0000 Am 23.03.21 um 20:00 schrieb Piotr Kubaj: > Hello, > > as Chris already mentioned, this is under a blanket approval. > > I think we can all agree that it's a simple and trivial patch. > I also think that it's simple enough that it would be hard to actually improve it (e.g. there are no helpers, so you wouldn't be able to suggest setting e.g. LLD_UNSAFE_powerpc). > It also doesn't break anything, because there is .if ${ARCH}. And still, a message would be nice if they just keep changing other people's ports. > > On 21-03-23 18:14:48, Jochen Neumeister wrote: >> It would be nice if you at least write an eMail before that you want to >> change something on someone else's port ..... >> >> Jochen >> >> >> >> Am 23.03.21 um 11:49 schrieb Piotr Kubaj: >>> Author: pkubaj >>> Date: Tue Mar 23 10:49:23 2021 >>> New Revision: 569017 >>> URL: https://svnweb.freebsd.org/changeset/ports/569017 >>> >>> Log: >>> databases/mysql57-server: don't use LLD for linking on powerpc >>> >>> LLD currently fails: >>> ld: error: relocation refers to a discarded section: .rodata._ZN5boost6detail8function15functor_managerINS_9algorithm6detail13token_finderFINS4_10is_any_ofFIcEEEEE7managerERKNS1_15function_bufferERSA_NS1_30functor_manager_operation_typeEN4mpl_5bool_ILb0EEE >>> >>> defined in ../../archive_output_directory/libmysqlpump_lib.a(object_filter.cc.o) >>> >>> referenced by object_filter.cc >>> >>> object_filter.cc.o:(.got2+0x108) in archive ../../archive_output_directory/libmysqlpump_lib.a >>> >>> ld: error: relocation refers to a discarded section: .rodata._ZN5boost6detail8function15functor_managerINS_9algorithm6detail13token_finderFINS4_10is_any_ofFIcEEEEE7managerERKNS1_15function_bufferERSA_NS1_30functor_manager_operation_typeEN4mpl_5bool_ILb0EEE >>> >>> defined in ../../archive_output_directory/libmysqlpump_lib.a(sql_formatter.cc.o) >>> >>> referenced by sql_formatter.cc >>> >>> sql_formatter.cc.o:(.got2+0x130) in archive ../../archive_output_directory/libmysqlpump_lib.a >>> >>> ld: error: relocation refers to a discarded section: .rodata._ZN5boost6detail8function15functor_managerINS_9algorithm6detail13token_finderFINS4_10is_any_ofFIcEEEEE7managerERKNS1_15function_bufferERSA_NS1_30functor_manager_operation_typeEN4mpl_5bool_ILb0EEE >>> >>> defined in ../../archive_output_directory/libmysqlpump_lib.a(table.cc.o) >>> >>> referenced by table.cc >>> >>> table.cc.o:(.got2+0x50) in archive ../../archive_output_directory/libmysqlpump_lib.a >>> clang++: error: linker command failed with exit code 1 (use -v to see invocation) >>> >>> Modified: >>> head/databases/mysql57-server/Makefile >>> >>> Modified: head/databases/mysql57-server/Makefile >>> ============================================================================== >>> --- head/databases/mysql57-server/Makefile Tue Mar 23 10:47:46 2021 (r569016) >>> +++ head/databases/mysql57-server/Makefile Tue Mar 23 10:49:23 2021 (r569017) >>> @@ -174,6 +174,10 @@ CC= ${LOCALBASE}/bin/clang${LLVM_DEFAULT} >>> CXX= ${LOCALBASE}/bin/clang++${LLVM_DEFAULT} >>> .endif >>> >>> +.if ${ARCH} == powerpc >>> +LLD_UNSAFE= yes >>> +.endif >>> + >>> post-extract: >>> @${RM} -rv ${WRKSRC}/sql/sql_hints.yy.cc ${WRKSRC}/sql/sql_hints.yy.h >>>