From owner-freebsd-bugs@FreeBSD.ORG Thu Aug 7 18:50:06 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 55DCC1065673 for ; Thu, 7 Aug 2008 18:50:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 43AA48FC29 for ; Thu, 7 Aug 2008 18:50:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m77Io6dQ025417 for ; Thu, 7 Aug 2008 18:50:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m77Io68D025416; Thu, 7 Aug 2008 18:50:06 GMT (envelope-from gnats) Date: Thu, 7 Aug 2008 18:50:06 GMT Message-Id: <200808071850.m77Io68D025416@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Alex Kozlov Cc: Subject: Re: bin/126324: [patch] rc.d/tmp: Prevent mounting /tmp in second time X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Alex Kozlov List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Aug 2008 18:50:06 -0000 The following reply was made to PR bin/126324; it has been noted by GNATS. From: Alex Kozlov To: Kris Kennaway , bug-followup@freebsd.org, spam@rm-rf.kiev.ua Cc: Subject: Re: bin/126324: [patch] rc.d/tmp: Prevent mounting /tmp in second time Date: Thu, 7 Aug 2008 21:49:03 +0300 On Thu, Aug 07, 2008 at 07:25:49PM +0200, Kris Kennaway wrote: > Alex Kozlov wrote: > > > Well, as alternative We can just don't touch /tmp if it already mounted. > This is much better on general grounds. I post patch for review soon. > > This also prevent md device leak at least until bin/114468 will be > > resolved. > > I don't like that PR since it introduces a layering violation, and > doesn't come with a justification of why it is necessary. > > Utilities that operate on filesystems shouldn't have knowledge about a > particular kind of backing store. I agree that this solution is a little ugly but also true that We need a simple way to garbage collect md devices. Current way is even more ugly: md=$(mount |grep ${mp}|cut -f1 -d' '); umount ${mp}; mdconfig -d -u ${md} -- Adios