From owner-cvs-all@FreeBSD.ORG  Thu Feb  5 22:15:31 2009
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8882A106567B
	for <cvs-all@FreeBSD.org>; Thu,  5 Feb 2009 22:15:31 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5])
	by mx1.freebsd.org (Postfix) with ESMTP id 15CA28FC27
	for <cvs-all@FreeBSD.org>; Thu,  5 Feb 2009 22:15:30 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 23158 invoked by uid 399); 5 Feb 2009 22:15:27 -0000
Received: from localhost (HELO ?192.168.0.19?) (dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTPAM; 5 Feb 2009 22:15:27 -0000
X-Originating-IP: 127.0.0.1
X-Sender: dougb@dougbarton.us
Message-ID: <498B64FE.9080101@FreeBSD.org>
Date: Thu, 05 Feb 2009 14:15:26 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: Stefan Walter <stefan@FreeBSD.org>
References: <200902050840.n158eurh096951@repoman.freebsd.org>
In-Reply-To: <200902050840.n158eurh096951@repoman.freebsd.org>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/mail/dkim-milter/files milter-dkim.sh.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Feb 2009 22:15:32 -0000

Stefan Walter wrote:
> stefan      2009-02-05 08:40:56 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     mail/dkim-milter/files milter-dkim.sh.in 
>   Log:
>   Fix a syntax error in the rc.d script.
>   
>   PR:             131161  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=131161
>   Submitted by:   "Ben C. O. Grimm" <freebsd@bengrimm.net>
>   
>   Revision  Changes    Path
>   1.16      +2 -2      ports/mail/dkim-milter/files/milter-dkim.sh.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dkim-milter/files/milter-dkim.sh.in.diff?&r1=1.15&r2=1.16&f=h

The milterdkim_flags default assignment is still wrong, it should be
done as the _alg default is done above it. Also, it's not necessary to
set empty defaults for anything except the _enable option. By default
rc.d handles empty variables appropriately.


hth,

Doug

-- 

    This .signature sanitized for your protection