From owner-cvs-src-old@FreeBSD.ORG Tue Jun 29 16:57:45 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D2F061065670 for ; Tue, 29 Jun 2010 16:57:45 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id BFD6E8FC22 for ; Tue, 29 Jun 2010 16:57:45 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o5TGvjP0050162 for ; Tue, 29 Jun 2010 16:57:45 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o5TGvjSQ050161 for cvs-src-old@freebsd.org; Tue, 29 Jun 2010 16:57:45 GMT (envelope-from glebius@repoman.freebsd.org) Message-Id: <201006291657.o5TGvjSQ050161@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to glebius@repoman.freebsd.org using -f From: Gleb Smirnoff Date: Tue, 29 Jun 2010 16:57:30 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet/ipfw ip_fw2.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jun 2010 16:57:45 -0000 glebius 2010-06-29 16:57:30 UTC FreeBSD src repository Modified files: sys/netinet/ipfw ip_fw2.c Log: SVN rev 209589 on 2010-06-29 16:57:30Z by glebius After processing the O_SKIPTO opcode our cmd points to the next rule, and "match" processing at the end of inner loop would look ahead into the next rule, which is incorrect. Particularly, in the case when the next rule started with F_NOT opcode it was skipped blindly. To fix this, exit the inner loop with the continue operator forcibly and explicitly. PR: kern/147798 Revision Changes Path 1.43 +3 -2 src/sys/netinet/ipfw/ip_fw2.c