From owner-freebsd-audit Wed Aug 22 1:44:26 2001 Delivered-To: freebsd-audit@freebsd.org Received: from ringworld.nanolink.com (dialmess.nanolink.com [217.75.135.246]) by hub.freebsd.org (Postfix) with SMTP id 23D4037B407 for ; Wed, 22 Aug 2001 01:44:20 -0700 (PDT) (envelope-from roam@ringlet.net) Received: (qmail 8628 invoked by uid 1000); 22 Aug 2001 08:42:41 -0000 Date: Wed, 22 Aug 2001 11:42:41 +0300 From: Peter Pentchev To: cjclark@alum.mit.edu Cc: freebsd-audit@freebsd.org Subject: Re: syslogd(8) Hostname Upgrade Message-ID: <20010822114241.C8189@ringworld.oblivion.bg> Mail-Followup-To: cjclark@alum.mit.edu, freebsd-audit@freebsd.org References: <20010822013841.A76483@blossom.cjclark.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010822013841.A76483@blossom.cjclark.org>; from cristjc@earthlink.net on Wed, Aug 22, 2001 at 01:38:41AM -0700 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Aug 22, 2001 at 01:38:41AM -0700, Crist J. Clark wrote: > I brought this up as a PR (bin/24444) some months ago. I figured I'd > finally close the PR and add this. > > This patch makes syslogd(8) update the hostname when the daemon is > reinitialized. Before anyone points it out, this is not meant to be a > security feature. It allows syslogd(8) to update the hostname without > terminating and restarting the daemon and generates a message logging > the change, nothing more, nothing less. > > I've been running with it for months on -CURRENT and -STABLE with no > problems. Nit picks anyone? Just one, and not a major one at that :) [snip] > /* > + * Load hostname (may have changed). > + */ > + if (signo) > + (void)strlcpy(oldLocalHostName, LocalHostName, > + sizeof(oldLocalHostName)); Do you really need the (void) here? If you want to make lint and friends happy, you should put the (void) in a couple of other places, too - like snprintf(), logmsg(), dprintf().. IMHO, just drop it. G'luck, Peter -- Nostalgia ain't what it used to be. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message