From owner-freebsd-current@FreeBSD.ORG Sat Oct 8 18:01:18 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5BB4106564A; Sat, 8 Oct 2011 18:01:18 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id A12DB8FC13; Sat, 8 Oct 2011 18:01:18 +0000 (UTC) Received: by iaby12 with SMTP id y12so475579iab.13 for ; Sat, 08 Oct 2011 11:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=hWWecgSSBsspZjvTRjE1Tl/eR+qU18IivIzWOKvn5Dg=; b=Av3+2XecqU/aePxJESWZgJzJKFDMaqHGhciNYH4aLh++WN9uQMnCE+P1qTupA5bO59 L6oOSdagew6Ay0kIuEZHZmSfI71JrdMVZUvrrBY2YlI9d2hQUYg4qUQhgeFm3cFdop1y qS68xG5H16iecPhi8CXIdFlqaX1eS6BGsatCM= MIME-Version: 1.0 Received: by 10.42.155.133 with SMTP id u5mr4801283icw.8.1318095313896; Sat, 08 Oct 2011 10:35:13 -0700 (PDT) Received: by 10.231.35.194 with HTTP; Sat, 8 Oct 2011 10:35:13 -0700 (PDT) Received: by 10.231.35.194 with HTTP; Sat, 8 Oct 2011 10:35:13 -0700 (PDT) In-Reply-To: <20111007164411.554ac9c0.stas@FreeBSD.org> References: <20111007230336.GB3051@laptop.levsha.me> <20111007164411.554ac9c0.stas@FreeBSD.org> Date: Sat, 8 Oct 2011 18:35:13 +0100 Message-ID: From: Chris Rees To: Stanislav Sedov Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Mykola Dzham , current@freebsd.org, pp@gmail.com, "portmgr@freebsd.org" , jilles@freebsd.org Subject: Re: ports on 10.0-CURRENT: r226027 is incorrect fix X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Oct 2011 18:01:19 -0000 On 8 Oct 2011 00:45, "Stanislav Sedov" wrote: > > On Sat, 8 Oct 2011 02:03:37 +0300 > Mykola Dzham mentioned: > > > Hi! > > r226027 fix ( ... s/freebsd1\*)/SHOULDNOTMATCHANYTHING1)/ ...) is > > incorrect: this commit breaks metaports building: > > > > # cd /usr/ports/print/teTeX && sudo make clean all > > ===> Cleaning for teTeX-3.0_5 > > ===> License check disabled, port has not defined LICENSE > > ===> Found saved configuration for teTeX-3.0_2 > > ===> Extracting for teTeX-3.0_5 > > ===> Patching for teTeX-3.0_5 > > ===> Configuring for teTeX-3.0_5 > > find /tmp/ports/usr/ports/print/teTeX/work/teTeX-3.0 -type f \( -name config.libpath -o -name config.rpath -o -name configure -o -name libtool.m4 \) -exec sed -i '' -e 's/freebsd1\*)/SHOULDNOTMATCHANYTHING1)/' -e 's/freebsd\[123\]\*)/SHOULDNOTMATCHANYTHING2)/' {} + > > find: /tmp/ports/usr/ports/print/teTeX/work/teTeX-3.0: No such file or directory > > *** Error code 1 > > > > Stop in /usr/ports/print/teTeX. > > *** Error code 1 > > > > Stop in /usr/ports/print/teTeX. > > > > I think this commit should be reverted. Using UNAME_r is less destructive work around > > > > Hi! > > I just committed the fix that checks if the ${WRKSRC} directory exists firts. > > Last I heard, portmgr explicitly disapproved of this fix-- have I missed something??? Erwin specifically said not to do it. Since when can anyone just commit stuff to bsd.port.mk, regardless of its location? This is a bad solution, please revert it or I will when I get back. We're going to end up being asked to support it on ports@ otherwise. Chris