From owner-svn-ports-all@FreeBSD.ORG Tue Jul 17 23:14:47 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 339D81065674 for ; Tue, 17 Jul 2012 23:14:47 +0000 (UTC) (envelope-from dougb@dougbarton.us) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with ESMTP id C22F78FC19 for ; Tue, 17 Jul 2012 23:14:46 +0000 (UTC) Received: (qmail 22591 invoked by uid 399); 17 Jul 2012 23:14:40 -0000 Received: from unknown (HELO ?172.17.194.139?) (dougb@dougbarton.us@12.207.105.210) by mail2.fluidhosting.com with ESMTPAM; 17 Jul 2012 23:14:40 -0000 X-Originating-IP: 12.207.105.210 X-Sender: dougb@dougbarton.us Message-ID: <5005F1E3.7080606@dougbarton.us> Date: Tue, 17 Jul 2012 16:14:43 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Alex Kozlov References: <201207172057.q6HKvEJc094784@svn.freebsd.org> <5005DB51.7050809@dougbarton.us> <5005E5C4.2030809@freebsd.org> <20120717230739.GA66332@ravenloft.kiev.ua> In-Reply-To: <20120717230739.GA66332@ravenloft.kiev.ua> X-Enigmail-Version: 1.4.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Niclas Zeising Subject: Re: svn commit: r301039 - head/archivers/zlib X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2012 23:14:47 -0000 On 07/17/2012 04:07 PM, Alex Kozlov wrote: > On Wed, Jul 18, 2012 at 12:23:00AM +0200, Niclas Zeising wrote: >> On 07/17/12 23:38, Doug Barton wrote: >>> Was this causing you some sort of specific problem? AFAIK this happens >>> often, possibly as a result of 'make makesum'. "Fixing" this everyplace >>> that it occurs would almost certainly cause a lot of needless churn. > > Actually, it's pretty rare occurrence, Maybe I'm just lucky then, because I see it all the time. > so it does not add much churn. > Also while harmless, this is still an error, like unused variable or typo. No, it's functionally quite different from either of those, since lack of a newline produces no actual problems. > I agree that ideally this type of change should be committed with > other changes, but it's hard to achieve because usually successive commits > are made by different committers. I'll let others comment as well, but ideally this particular change wouldn't be committed at all unless that particular file was being changed otherwise. > Would be even better to find out why it happens at all, but i've done > thousands of tests and still can't reproduce it with make makesum. I agree that finding out why it happens would be interesting, but we've got bigger fish to fry. > It's not necessary. Then let's not do it. :) Doug