From owner-svn-src-head@FreeBSD.ORG Sat Mar 28 19:17:39 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D85371065679 for ; Sat, 28 Mar 2009 19:17:39 +0000 (UTC) (envelope-from christoph.mallon@gmx.de) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mx1.freebsd.org (Postfix) with SMTP id 26F878FC2B for ; Sat, 28 Mar 2009 19:17:38 +0000 (UTC) (envelope-from christoph.mallon@gmx.de) Received: (qmail invoked by alias); 28 Mar 2009 19:17:37 -0000 Received: from p54A3EDAD.dip.t-dialin.net (EHLO tron.homeunix.org) [84.163.237.173] by mail.gmx.net (mp041) with SMTP; 28 Mar 2009 20:17:37 +0100 X-Authenticated: #1673122 X-Provags-ID: V01U2FsdGVkX18JgwchpFoJd7IFFL6aaY9bRRzdo1dQQjVIJNYWXE d4IQySN0FQi0QV Message-ID: <49CE77CE.3040801@gmx.de> Date: Sat, 28 Mar 2009 20:17:34 +0100 From: Christoph Mallon User-Agent: Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: Julian Elischer References: <49C5737F.1050902@gmx.de> <20090321.175756.-434257642.imp@bsdimp.com> <49C5F88C.3070600@freebsd.org> <20090322.070349.195750067.imp@bsdimp.com> <49C68197.1060204@elischer.org> In-Reply-To: <49C68197.1060204@elischer.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.66 Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, avg@FreeBSD.org, marius@alchemy.franken.de, svn-src-head@FreeBSD.org, "M. Warner Losh" Subject: Re: svn commit: r190098 - in head/sys/sparc64: fhc sparc64 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2009 19:17:40 -0000 Julian Elischer schrieb: > M. Warner Losh wrote: >> In message: <49C5F88C.3070600@freebsd.org> >> Andriy Gapon writes: >> : E.g. you can have a simple 3 line block where you need a local variable >> : but that block is located 50 lines from start of an enclosing function. >> : Very convenient when you need to quickly glance the variable's type >> (not). >> >> No you don't. There's absolutely nothing wrong with putting them at >> the top. In fact, it is simpler, really, than having to go hunting >> for dozens of different declarations. As someone who has spent a lot >> of time looking at code, the time wasted looking for these damn-fool >> things really adds up. > > and in a complicated function, if you have them all over the place you > have no idea as to what the potential stack usage of the function is.. > This matters in the kernel. The declared local variables are neither a lower *nor* an upper bound for stack usage.