From owner-freebsd-gecko@FreeBSD.ORG  Fri Aug 19 16:12:50 2011
Return-Path: <owner-freebsd-gecko@FreeBSD.ORG>
Delivered-To: gecko@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AD6271065674;
	Fri, 19 Aug 2011 16:12:50 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 91F4E8FC25;
	Fri, 19 Aug 2011 16:12:49 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA02022;
	Fri, 19 Aug 2011 19:12:48 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Message-ID: <4E4E8B7F.4090001@FreeBSD.org>
Date: Fri, 19 Aug 2011 19:12:47 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:5.0) Gecko/20110705 Thunderbird/5.0
MIME-Version: 1.0
To: Alex Dupre <ale@FreeBSD.org>
References: <201108181007.p7IA7PgK032094@repoman.freebsd.org>
	<4E4D6AD3.2050708@FreeBSD.org> <4E4D70FF.2060206@FreeBSD.org>
	<4E4DCFED.4070601@FreeBSD.org> <4E4E05BA.9070707@FreeBSD.org>
	<4E4E7A69.8050406@FreeBSD.org> <4E4E7D5D.4050204@FreeBSD.org>
	<4E4E812B.6000007@FreeBSD.org> <4E4E82C6.9040606@FreeBSD.org>
	<4E4E85D7.4070709@FreeBSD.org>
In-Reply-To: <4E4E85D7.4070709@FreeBSD.org>
X-Enigmail-Version: 1.2pre
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: gecko@FreeBSD.org, Doug Barton <dougb@FreeBSD.org>
Subject: Re: cvs commit: ports UPDATING ports/mail/enigmail Makefile distinfo
 pkg-message ports/mail/enigmail-thunderbird Makefile
X-BeenThere: freebsd-gecko@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Gecko Rendering Engine issues <freebsd-gecko.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gecko>,
	<mailto:freebsd-gecko-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gecko>
List-Post: <mailto:freebsd-gecko@freebsd.org>
List-Help: <mailto:freebsd-gecko-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gecko>,
	<mailto:freebsd-gecko-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Aug 2011 16:12:50 -0000

on 19/08/2011 18:48 Andriy Gapon said the following:
> OK, it seems that the culprit is mozilla/toolkit/xre/glxtest.cpp:
> fire_glxtest_process() forks a new process, but doesn't wait(2) for it.
> So when wait(2) is invoked later it may return a pid of this child before any
> other child.
> Not sure how to fix this or work around it.
> Maybe by adding wait4(WNOHANG) loop to the _MD_InitProcesses code... not sure how
> robust that would be.  Or maybe glxtest should use PR_CreateProcess instead of the
> plain fork(2) that it uses now...

I ended up forcing an explicit wait on the glxtest child:
--- mozilla/toolkit/xre/glxtest.cpp.orig	2011-08-19 18:57:10.604870746 +0300
+++ mozilla/toolkit/xre/glxtest.cpp	2011-08-19 18:59:43.620447963 +0300
@@ -51,6 +51,8 @@
 // which runs the glxtest() static function. This creates a X connection, a GLX
context, calls glGetString, and writes that
 // to the 'write' end of the pipe.

+#include <sys/types.h>
+#include <sys/wait.h>
 #include <cstdio>
 #include <cstdlib>
 #include <unistd.h>
@@ -224,6 +226,7 @@
 void fire_glxtest_process()
 {
   int pfd[2];
+  int status;
   if (pipe(pfd) == -1) {
       perror("pipe");
       exit(EXIT_FAILURE);
@@ -244,4 +247,5 @@
   close(pfd[1]);
   mozilla::widget::glxtest_pipe = pfd[0];
   mozilla::widget::glxtest_pid = pid;
+  waitpid(pid, &status, 0);
 }

This patch does help me.

-- 
Andriy Gapon