From owner-cvs-all Tue Apr 2 10: 2:30 2002 Delivered-To: cvs-all@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id F0A8637B405; Tue, 2 Apr 2002 10:02:21 -0800 (PST) Received: (from dillon@localhost) by apollo.backplane.com (8.11.6/8.9.1) id g32I2IY16755; Tue, 2 Apr 2002 10:02:18 -0800 (PST) (envelope-from dillon) Date: Tue, 2 Apr 2002 10:02:18 -0800 (PST) From: Matthew Dillon Message-Id: <200204021802.g32I2IY16755@apollo.backplane.com> To: Kenneth Culver Cc: Mike Barcroft , "M. Warner Losh" , , , Subject: Re: cvs commit: src/sys/i386/i386 critical.c src/sys/i386/include cpufunc.h critical.h src/sys/i386/isa apic_vector.s icu_vector.s src/sys/kern kern_fork.c kern_proc.c kern_switch.c src/sys/alpha/alph References: <20020402100957.C45652-100000@alpha.yumyumyum.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :> > x; :> > y; :> > } else :> > /* :> > * HITHERE! :> > */ :> > b; :> :> This looks better with proper 8 character tabs. I think in KNF extra :> braces are normally used in situations like this, but this is an edge :> case. : :8 character tabs? why use tabs at all? That requires an :engineer/programmer to set that in an editor, and a lot of people don't :like having tabs that are that large... I just use spaces because then my :code will look the same as when I wrote it no matter what editor is used, :and no matter what the tabs are set to. Ha. This argument goes back forever. In the early days people used all sorts of different indentation. 2, 3, 4, 8... everything under the sun. In those days disk space was at a premium, so many of these people changed the interpretation of a 'hard tab' to match their indentation. It caused no end of trouble. Source code would often not be portable between text editors or even be printable without some massaging. This is, amoung other things, what led to vi's first-line-of-file-contains-vi- options feature. These days virtually everyone I know who used to use weird tabbing conventions now uses hard tabs of 8, period, no matter what their favorite indentation is. So if you look at a piece of code that uses an indentation of 4 you will find that every other indentation level has a bunch of spaces to make up the difference. a b c d <4xSPACE> + a + b + <4xSPACE> + c + + d Even though disk space is no longer at a premium, it still offends people's sensibilities when they see a source file bloated to 2x or 3x its normal size when spaces are used to handle deep indentations. So tabs (fixed at 8) still have meaning. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message