From owner-freebsd-net@FreeBSD.ORG Mon Mar 8 20:03:34 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 03A3F106564A for ; Mon, 8 Mar 2010 20:03:34 +0000 (UTC) (envelope-from dhorn2000@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.152]) by mx1.freebsd.org (Postfix) with ESMTP id 864228FC1F for ; Mon, 8 Mar 2010 20:03:33 +0000 (UTC) Received: by fg-out-1718.google.com with SMTP id 22so1083698fge.13 for ; Mon, 08 Mar 2010 12:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=OnqKEdrScu4Ke4vrUlfVLGXv99ysILSHHpHh2/mnRZk=; b=HdvVrY6IRk5Og5I69mbOf0kkT64AgHWW0L+eY6/GLeBldjixABT2Oxh+a2BPvOM9Sh gipsUOOUSD9hEIIdI0Kd6tk9aAb/jHhX9KZlLNbMtHypNGMDSOlHIT4toibQk4l4lrhj cOYQS8BjqvV5AeIDypK5S3ImpZzhElsQDXC84= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=ZZG5G5ntGv/40nuqbqK+4F8J/tUCTI0dfhlmwvnme2xh+DLhzMNVxfRWMOH1nOnUPL h19Qee0TtnOn29Cc37BnmdgX4nsR6Xy6mpvPK94Dr4SHdZP0ognyX7mnlHs7Ik2cCGDJ HWHKlG/NJoJxYukX9rhYxhuy2ia7mfWpF00j0= MIME-Version: 1.0 Received: by 10.87.20.13 with SMTP id x13mr8057226fgi.67.1268078609185; Mon, 08 Mar 2010 12:03:29 -0800 (PST) In-Reply-To: <20100308193246.GB38183@citylink.fud.org.nz> References: <4B954C19.9050606@delphij.net> <20100308193246.GB38183@citylink.fud.org.nz> Date: Mon, 8 Mar 2010 15:03:29 -0500 Message-ID: <25ff90d61003081203w48829572v37709d866eaae165@mail.gmail.com> From: David Horn To: Andrew Thompson Content-Type: multipart/mixed; boundary=001636458c900c3d5c04814f8f2a Cc: freebsd-net@freebsd.org, d@delphij.net Subject: Re: Why lagg(4) wants ~IFF_DRV_OACTIVE? X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2010 20:03:34 -0000 --001636458c900c3d5c04814f8f2a Content-Type: text/plain; charset=ISO-8859-1 On Mon, Mar 8, 2010 at 2:32 PM, Andrew Thompson wrote: > On Mon, Mar 08, 2010 at 11:12:25AM -0800, Xin LI wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Hi, >> >> Maybe this is a stupid question but I really don't understand why a >> interface with IFF_DRV_OACTIVE can't be added to a lagg(4) interface. >> Looking at OpenBSD code, they do this since the day 0. >> >> Could anyone shed some light, why we need to enforce this check? :) > > I think it was just carried over, I dont see any reason to keep it. That's good news. Someone, please review and commit attached patch for sys/net/if_lagg.c. This also fixes my PR: kern/139117. --Thanks! --_Dave Horn --001636458c900c3d5c04814f8f2a Content-Type: text/plain; charset=US-ASCII; name="lagg_oactive.diff.txt" Content-Disposition: attachment; filename="lagg_oactive.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g6jp6ofj0 SW5kZXg6IGlmX2xhZ2cuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBpZl9sYWdnLmMJKHJldmlzaW9uIDIwNDg3 NykKKysrIGlmX2xhZ2cuYwkod29ya2luZyBjb3B5KQpAQCAtNDg0LDEwICs0ODQsNiBAQAogCWlm IChzYy0+c2NfY291bnQgPj0gTEFHR19NQVhfUE9SVFMpCiAJCXJldHVybiAoRU5PU1BDKTsKIAot CS8qIE5ldyBsYWdnIHBvcnQgaGFzIHRvIGJlIGluIGFuIGlkbGUgc3RhdGUgKi8KLQlpZiAoaWZw LT5pZl9kcnZfZmxhZ3MgJiBJRkZfRFJWX09BQ1RJVkUpCi0JCXJldHVybiAoRUJVU1kpOwotCiAJ LyogQ2hlY2sgaWYgcG9ydCBoYXMgYWxyZWFkeSBiZWVuIGFzc29jaWF0ZWQgdG8gYSBsYWdnICov CiAJaWYgKGlmcC0+aWZfbGFnZyAhPSBOVUxMKQogCQlyZXR1cm4gKEVCVVNZKTsK --001636458c900c3d5c04814f8f2a--